Add WnafBase::multiscalar_mul again#22
Closed
tarcieri wants to merge 21 commits into
Closed
Conversation
NOTE: depends on zkcrypto/ff#149 Release notes for `rand_core` v0.10.0: https://github.com/rust-random/rand_core/releases/tag/v0.10.0
This unifies the methods previously exposed by the `PrimeCurveAffine` and `CofactorCurveAffine` traits. The prime-order and cofactor traits are now all marker traits, and their affine-specific traits are automatically derived.
Introduce `CurveAffine` trait
Bump `rand_core` to v0.10; MSRV 1.85
Matches the naming adopted in zkcrypto/rfcs#1.
Release 0.14.0
Computes a sum-of-products `aA + bB + ...` in variable time with w-NAF
multi-exponentiation using the interleaved window method, also known
as Straus' method.
The key insight is that when computing this sum by means of additions
and doublings, the doublings can be shared by performing the additions
within an inner loop.
The API and implementation are inspired in part by `curve25519-dalek`,
namely the `VartimeMultiscalarMul` trait and corresponding
implementation in `straus.rs`.
This results in ~28% speedup on `p256` for a 3 scalar/point input:
ProjectivePoint operations/point-scalar lincomb (variable-time)
time: [149.13 µs 149.80 µs 150.84 µs]
change: [−27.999% −27.645% −27.267%] (p = 0.00 < 0.05)
This is closer to the `VartimeMultiscalarMul` trait in `curve25519-dalek`.
This merges the multiscalar multiplication implementation proposed in zkcrypto#85 into the RustCrypto fork so we can try it out. Originally added as RustCrypto#14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges the multiscalar multiplication implementation proposed in zkcrypto#85 into the RustCrypto fork so we can try it out.
Originally added as #14