Skip to content

Comments

Support pipewire as host#1093

Open
Decodetalkers wants to merge 73 commits intoRustAudio:masterfrom
Decodetalkers:pipewire
Open

Support pipewire as host#1093
Decodetalkers wants to merge 73 commits intoRustAudio:masterfrom
Decodetalkers:pipewire

Conversation

@Decodetalkers
Copy link
Contributor

@Decodetalkers Decodetalkers commented Jan 6, 2026 •
edited
Loading

Add support to pipewire

You can test it with pipewire feature open

Pipewire support use config to define rates. So the default config of cpal with pipewire can be changed through config like following.

cat ~/.config/pipewire/pipewire.conf.d/custom-rates.conf
context.properties = {
    default.clock.rate          = 48000
    default.clock.allowed-rates = [ 44100 48000 88200 96000 176400 192000 ]
}

Still problems left:

*once we do 'pipewire::init', we can only dequeue it after the whole thread. even put the function to another thread, the function still works.. But seems we can run init many times.. (Ok, seems it is not a problem, because in when we call init, the init action will only be called once. I think it will be ok)
*The crates by pipewire need edition 2024. I think that should be another pr.

@Decodetalkers Decodetalkers marked this pull request as draft January 6, 2026 12:20
@Decodetalkers Decodetalkers changed the title Pipewire support Support pipewire as host Jan 6, 2026
@Decodetalkers Decodetalkers marked this pull request as ready for review January 6, 2026 14:41
@Decodetalkers Decodetalkers force-pushed the pipewire branch 4 times, most recently from 9e2ef9f to fd59a29 Compare January 6, 2026 14:57
@Decodetalkers
Copy link
Contributor Author

Decodetalkers commented Jan 6, 2026

Seems pipewire need edition 2024..

@Decodetalkers
Copy link
Contributor Author

Decodetalkers commented Jan 7, 2026

@roderickvd can you help review this pr? Thanks, and when can this crate be upgraded to edition 2024? I would also want to help

@roderickvd
Copy link
Member

roderickvd commented Jan 7, 2026

@roderickvd can you help review this pr?

Definitely will help you review it. Need a bit more time.

Thanks, and when can this crate be upgraded to edition 2024? I would also want to help

Actually cpal itself doesn't need to be upgraded to Rust 2024, it just needs a MSRV of Rust of 1.85 or higher to support dependencies that are Rust 2024 already.

When we can I'd like to stick cpal to Rust 2021 so we keep our MSRV down.

@SuperKenVery
Copy link
Contributor

SuperKenVery commented Jan 8, 2026

Super cool man! Happy to see cpal having better linux support, opening the possibility of loopback recording on Linux!

@Decodetalkers Decodetalkers force-pushed the pipewire branch 3 times, most recently from 07bc999 to 6cea2ad Compare January 9, 2026 22:31
@Decodetalkers
Copy link
Contributor Author

Decodetalkers commented Jan 9, 2026

ok, only one ci that I cannot fix

@Decodetalkers Decodetalkers force-pushed the pipewire branch 3 times, most recently from a81e104 to 5a3817c Compare January 10, 2026 16:19
@Decodetalkers
Copy link
Contributor Author

Decodetalkers commented Jan 10, 2026

ok cross-rs based on ubuntu20.04, so

@Decodetalkers Decodetalkers force-pushed the pipewire branch 9 times, most recently from 721beb0 to 424d78f Compare January 11, 2026 09:53
@Be-ing
Copy link
Contributor

Be-ing commented Jan 15, 2026

How does this differ from #692?

roderickvd
roderickvd reviewed Feb 24, 2026
View reviewed changes
_typos.toml Outdated
Copy link
Member

@roderickvd roderickvd Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file necessary? Can we remove it?

Copy link
Contributor Author

@Decodetalkers Decodetalkers Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. seems typos-lsp add it automately

Copy link
Contributor Author

@Decodetalkers Decodetalkers Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. because the function of datas seems a typo for typos-lsp, and I accidentally invoke that action. Now I deleted it

roderickvd
roderickvd reviewed Feb 24, 2026
View reviewed changes
src/host/pipewire/device.rs Outdated
Source,
}

#[allow(dead_code)]
Copy link
Member

@roderickvd roderickvd Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one I mean: please do not set it on the entire struct, but only on any fields that need it. Better yet consider if we cannot remove fields we don't use.

Copy link
Contributor Author

@Decodetalkers Decodetalkers Feb 25, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, done

roderickvd
roderickvd reviewed Feb 24, 2026
View reviewed changes
src/host/pipewire/device.rs Outdated
D: FnMut(&mut crate::Data, &crate::OutputCallbackInfo) + Send + 'static,
E: FnMut(crate::StreamError) + Send + 'static,
{
let (pw_play_tx, pw_play_rv) = pw::channel::channel::<StreamCommand>();
Copy link
Member

@roderickvd roderickvd Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are two _rvs that should be changed into _rx.

Copy link
Contributor Author

@Decodetalkers Decodetalkers Feb 25, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the time is named with "Receiver", so I think it should named as rv.. I see, I will change it, I misunderstood the x meaning

roderickvd
roderickvd reviewed Feb 24, 2026
View reviewed changes
examples/record_wav.rs Outdated
),
feature = "jack"
feature = "jack",
not(feature = "pipewire")
Copy link
Member

@roderickvd roderickvd Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks with --features jack,pipewire. Let's make sure it works all ways.

Copy link
Contributor Author

@Decodetalkers Decodetalkers Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sync the way in beep.rs

roderickvd
roderickvd reviewed Feb 24, 2026
View reviewed changes
roderickvd
roderickvd reviewed Feb 24, 2026
View reviewed changes
src/host/pipewire/stream.rs Outdated
SampleFormat::F64 => Self::F64LE,
#[cfg(target_endian = "big")]
SampleFormat::F64 => Self::F64BE,
// TODO: maybe we also need to support others
Copy link
Member

@roderickvd roderickvd Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe specify that PipeWire does support U64 and I64, but libspa doesn't yet.

Copy link
Contributor Author

@Decodetalkers Decodetalkers Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

roderickvd
roderickvd reviewed Feb 24, 2026
View reviewed changes
roderickvd
roderickvd reviewed Feb 24, 2026
View reviewed changes
roderickvd
roderickvd reviewed Feb 24, 2026
View reviewed changes
roderickvd
roderickvd reviewed Feb 24, 2026
View reviewed changes
@Decodetalkers
chore: remove limit_quantum
769c8d7 
it is meaningful, but not used in this repo
@Decodetalkers Decodetalkers reopened this Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roderickvd roderickvd Awaiting requested review from roderickvd

2 more reviewers

@Be-ing Be-ing Be-ing left review comments

@yara-blue yara-blue yara-blue left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Decodetalkers @roderickvd @SuperKenVery @Be-ing @Frando @vasyl-protsiv @edwloef @yara-blue @loxoron218