print: attempt to improve GlobalVar printing by using named arguments.#23
Open
eddyb wants to merge 2 commits intoRust-GPU:mainfrom
Open
print: attempt to improve GlobalVar printing by using named arguments.#23eddyb wants to merge 2 commits intoRust-GPU:mainfrom
GlobalVar printing by using named arguments.#23eddyb wants to merge 2 commits intoRust-GPU:mainfrom
Conversation
eddyb
force-pushed
the
gv-print
branch
2 times, most recently
from
84ecf4c to
f90c442
Compare
LegNeato
previously approved these changes
Aug 18, 2025
Collaborator
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
Looks reasonable, only used this once myself and you are probably the main/only consumer right now 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty small aesthetic improvement (or at least making global vars more like other constructs where pretty-printing relies on "named arguments"), that happened to be independent enough to land separately.
Quick examples (tho note that
data(...)blobs and&F...pointers require other other changes):I don't have a "before" on hand for either of those, but they involved
layout(...)aroundsize/align, thespv.StorageClass.Privatewould be separate with a keyword, andinitmight've used= ....(if there is more interest, I can spend extra time on that, but this is IMO not that important)