Skip to content

Point LLVM 21 prebuilt URLs at the upstream release - #413

Open
brandonros wants to merge 2 commits into
Rust-GPU:mainfrom
brandonros:fix/llvm21-upstream-urls
Open

brandonros wants to merge 2 commits into
Rust-GPU:mainfrom
brandonros:fix/llvm21-upstream-urls

Conversation

@brandonros

Copy link
Copy Markdown
Contributor

Follow-up to #408. The upstream Rust-GPU/rustc_codegen_nvvm-llvm llvm-21.1.8 release is now published with all three archives, so the Linux CI fallback PREBUILT_LLVM_URL and the guide example now point at it instead of the brandonros fork. build.rs already defaulted to upstream.

🤖 Generated with Claude Code

The Rust-GPU/rustc_codegen_nvvm-llvm llvm-21.1.8 release is now published,
so the CI fallback and guide example no longer need the fork.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@brandonros

Copy link
Copy Markdown
Contributor Author

@LegNeato oops :) we probably want this

The merge job for rust-cuda-ubuntu24-cuda13 downloaded digests-rust-cuda-ubuntu24-cuda13-*,
which also matched the rust-cuda-ubuntu24-cuda13-llvm21 artifacts, so imagetools create
failed looking up llvm21 digests in the cuda13 repo. Put the arch first so the image name
is the anchored suffix of the pattern.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@brandonros

Copy link
Copy Markdown
Contributor Author

Added 44ff9e0 to fix the Create manifest for Ubuntu-24.04/CUDA-13.3.1 failure on main (run):

ERROR: ghcr.io/rust-gpu/rust-cuda-ubuntu24-cuda13@sha256:5870e0e8...: not found

Cause: each build job uploads its digest as digests-<image>-<arch>, and the merge job downloads digests-<image>-*. For rust-cuda-ubuntu24-cuda13, that pattern also matches the rust-cuda-ubuntu24-cuda13-llvm21 artifacts. The download step fetched 4 artifacts instead of 2:

- digests-rust-cuda-ubuntu24-cuda13-llvm21-amd64
- digests-rust-cuda-ubuntu24-cuda13-llvm21-arm64
- digests-rust-cuda-ubuntu24-cuda13-arm64
- digests-rust-cuda-ubuntu24-cuda13-amd64

imagetools create then looked for the llvm21 digests in the rust-cuda-ubuntu24-cuda13 repo, where they don't exist. The other manifest jobs passed because no other image name starts with theirs.

Fix: put the arch first (digests-<arch>-<image>) and download digests-*-<image>. The image name is now the end of the pattern, so -llvm21 artifacts no longer match.

These steps only run on non-PR events, so this PR's CI won't test the change. The first real test is the next push to main.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant