Skip to content

build: support systems without O_CLOEXEC - #1101

Open
steadytao wants to merge 4 commits into
masterfrom
solaris-o-cloexec
Open

steadytao wants to merge 4 commits into
masterfrom
solaris-o-cloexec

Conversation

@steadytao

Copy link
Copy Markdown
Member

Fixes #1100

Summary

  • move the existing O_CLOEXEC fallback into the shared header
  • remove the duplicated function-local fallbacks
  • add a compile-only check for rsync.c without O_CLOEXEC
  • update the existing authentication portability regression to exercise the shared fallback

@steadytao

Copy link
Copy Markdown
Member Author

@idgn23 Could you please verify?

@steadytao

Copy link
Copy Markdown
Member Author

@idgn23 Bump.

@idgn23

idgn23 commented Sep 28, 2026

Copy link
Copy Markdown

Will verify within this week. Had a busy week last week.

@steadytao

Copy link
Copy Markdown
Member Author

No worries. Please take as much time as you need.

@idgn23

idgn23 commented Oct 1, 2026

Copy link
Copy Markdown

Looks better, but there is now a different issue:
/opt/SUNWspro/bin/cc -I. -I. -I./zlib -xO3 -m32 -xarch=sparc -DHAVE_CONFIG_H -I/opt/csw/include -c params.c -o params.o
gawk -f ./define-from-md.awk -v hfile=default-dont-compress.h ./rsync.1.md
/opt/SUNWspro/bin/cc -I. -I. -I./zlib -xO3 -m32 -xarch=sparc -DHAVE_CONFIG_H -I/opt/csw/include -c loadparm.c -o loadparm.o
/opt/SUNWspro/bin/cc -I. -I. -I./zlib -xO3 -m32 -xarch=sparc -DHAVE_CONFIG_H -I/opt/csw/include -c clientserver.c -o clientserver.o
"clientserver.c", line 1621: undefined symbol: O_DIRECTORY
cc: acomp failed for clientserver.c
gmake: *** [Makefile:76: clientserver.o] Error 2

@steadytao

Copy link
Copy Markdown
Member Author

Oh. The other shared flag is broken too. Alright, give me a bit.

@steadytao

Copy link
Copy Markdown
Member Author

Thank you.

@steadytao

Copy link
Copy Markdown
Member Author

@idgn23 When you are next available please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build error on Solaris 10 / SPARC

2 participants