testsuite: ssh-basic: split the quoted rsh command before exec'ing it - #1098
Merged
Merged
Conversation
rsh_cmd() returns the lsh.sh path quoted for rsync's own --rsh tokenizer, so a build directory containing a character shlex.quote() will not pass bare -- the '~' in a Debian snapshot version such as rsync-3.5.1~git20260921 -- comes back wrapped in quotes. The ssh-basic probe passed that string straight to subprocess.run() as argv[0], where no shell strips the quotes, and failed with FileNotFoundError. Split it with shlex first. Found via the rsync-latest PPA, where every snapshot build fails `make check` on exactly this test while the release builds pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rsh_cmd() returns the lsh.sh path quoted for rsync's own --rsh tokenizer, so a build directory containing a character shlex.quote() will not pass bare -- the '
' in a Debian snapshot version such as rsync-3.5.1git20260921 -- comes back wrapped in quotes. The ssh-basic probe passed that string straight to subprocess.run() as argv[0], where no shell strips the quotes, and failed with FileNotFoundError. Split it with shlex first.Found via the rsync-latest PPA, where every snapshot build fails
make checkon exactly this test while the release builds pass.