chore: remove useCorsSSLConfig hook and absoluteUrl startup patch#40352
chore: remove useCorsSSLConfig hook and absoluteUrl startup patch#40352billywithaw1lly wants to merge 3 commits intoRocketChat:developfrom
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 5c6e552 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request removes dead code following Meteor DDP layer removal. The changes delete an Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Remove
useCorsSSLConfighook and theabsoluteUrlstartup patch — both are dead code that only existed to patchMeteor.absoluteUrl'ssecureandrootUrldefaults, which have no consumers once the Meteor webapp/DDP layer is removed. Both files contain TODO comments explicitly marking them for removal.apps/meteor/client/views/root/hooks/useCorsSSLConfig.tsapps/meteor/client/meteor/startup/absoluteUrl.tsuseCorsSSLConfig()call and import fromAppLayout.tsxabsoluteUrlstartup import frommeteor/startup/index.tsCloses #40349
Closes #40348
No functional changes — this is dead code removal. Verify no remaining references by running:
grep -r "useCorsSSLConfig" apps/meteor/client/
Straightforward cleanup. No behavior changes expected.
Summary by CodeRabbit