Skip to content

chore: remove useCorsSSLConfig hook and absoluteUrl startup patch#40352

Open
billywithaw1lly wants to merge 3 commits intoRocketChat:developfrom
billywithaw1lly:remove-useCorsSSLConfig
Open

chore: remove useCorsSSLConfig hook and absoluteUrl startup patch#40352
billywithaw1lly wants to merge 3 commits intoRocketChat:developfrom
billywithaw1lly:remove-useCorsSSLConfig

Conversation

@billywithaw1lly
Copy link
Copy Markdown

@billywithaw1lly billywithaw1lly commented Apr 30, 2026

Remove useCorsSSLConfig hook and the absoluteUrl startup patch — both are dead code that only existed to patch Meteor.absoluteUrl's secure and rootUrl defaults, which have no consumers once the Meteor webapp/DDP layer is removed. Both files contain TODO comments explicitly marking them for removal.

  • Deleted apps/meteor/client/views/root/hooks/useCorsSSLConfig.ts
  • Deleted apps/meteor/client/meteor/startup/absoluteUrl.ts
  • Removed useCorsSSLConfig() call and import from AppLayout.tsx
  • Removed absoluteUrl startup import from meteor/startup/index.ts

Closes #40349
Closes #40348

No functional changes — this is dead code removal. Verify no remaining references by running:
grep -r "useCorsSSLConfig" apps/meteor/client/

Straightforward cleanup. No behavior changes expected.

Summary by CodeRabbit

  • Chores
    • Removed unused SSL/CORS configuration hook from application initialization
    • Removed deprecated startup patch that was no longer required
    • Cleaned up dead code references from the startup process

@billywithaw1lly billywithaw1lly requested a review from a team as a code owner April 30, 2026 21:16
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Apr 30, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 30, 2026

🦋 Changeset detected

Latest commit: 5c6e552

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/abac Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/server-fetch Patch
@rocket.chat/ui-video-conf Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 30, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

Walkthrough

This pull request removes dead code following Meteor DDP layer removal. The changes delete an absoluteUrl startup patch, a useCorsSSLConfig hook that modified URL handling defaults, and their corresponding imports throughout the codebase.

Changes

Cohort / File(s) Summary
Changeset metadata
.changeset/tame-falcons-watch.md
New changeset entry documenting the removal of useCorsSSLConfig hook and absoluteUrl startup patch as dead code after Meteor DDP removal.
Startup configuration removal
apps/meteor/client/meteor/startup/absoluteUrl.ts, apps/meteor/client/meteor/startup/index.ts
Deleted startup script that patched Meteor.absoluteUrl with CORS/SSL handling, and removed its import from the startup entrypoint.
Hook removal
apps/meteor/client/views/root/hooks/useCorsSSLConfig.ts
Deleted hook that subscribed to Force_SSL UI setting and mutated absoluteUrl.defaultOptions.secure.
Hook reference cleanup
apps/meteor/client/views/root/AppLayout.tsx
Removed import and invocation of useCorsSSLConfig hook during component lifecycle.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title accurately summarizes the primary changes: removing the useCorsSSLConfig hook and absoluteUrl startup patch, which aligns with the changeset and all modified files.
Linked Issues check ✅ Passed The pull request fulfills issue #40349 by removing the useCorsSSLConfig hook and related Meteor.absoluteUrl patching code, as required.
Out of Scope Changes check ✅ Passed All changes are in scope: the PR removes only the useCorsSSLConfig hook, absoluteUrl startup patch, and their references per issue #40349.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove this hook together with the Meteor webapp/DDP layer — it only remove this file together with the Meteor webapp/DDP layer — it only

2 participants