Open
Conversation
* nolonger create a connection table for each connection to a binding * use a boolean for indicating if a callback is suspended * only use one callbacks table, instead of one for suspended callbacks and one for all callbacks
Author
Ran on:
Benchmark place: ReactBindingRewriteBenchmark.zip |
* make naming of bindings consistent * improve error messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Rewrites ReactBinding to be cleaner, and also use less memory as its now properly using metatables.
__subscribeToBindingas depricated as every binding now has a:_subscribe()method that should be used instead_:subscribe()updatefunction not iterate twice when firing off callbacksChecklist before submitting: