Repository navigation
refactor(release): move the agent-image index publish logic into a tested tool - #1804
Merged
trunk-io[bot] merged 2 commits intoOct 7, 2026
Conversation
…sted tool tools/agent-image-index composes, guards, publishes and verifies the compass-agent OCI index with the same checks the inline shell made. bun:test drives the decision paths with fake git, skopeo and podman results. The job now installs nix and the pinned bun to run it. Refs RIG-4735 Co-authored-by: Matt Wilkinson <matt@rigel.build>
- Assert the :git push precedes the :latest push. - Assert trailing newlines on raw inspect output do not change the digest, matching the shell's command-substitution behaviour. - Keep the inspect stderr in the ambiguous :git refusal message. Refs RIG-4735 Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Compass engineering docs preview: https://compass-native-rig-4735-inde.compass-eng-docs.pages.dev Deployed from |
rigel-mintaka
marked this pull request as ready for review
October 6, 2026 20:38
mattwilkinsonn
added this pull request to stack #1836
October 7, 2026 00:39
mattwilkinsonn
approved these changes
Oct 7, 2026
Contributor
|
/trunk merge |
|
😎 Stack merged successfully - details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish-image-manifestfrom inline shell intotools/agent-image-index, a bun tool. The logic covers: compose the index by digest, guard:git-<sha12>, the:latestordering guard, and verify. A pure core takes an injected command runner; the edge usesBun.spawnwith argument arrays.::error::messages. The one addition: the ambiguous:gitrefusal now includes the inspect stderr, which the shell printed separately.gate-tools.nixon PATH. The tool has no runtime dependencies, so there is nobun install.bun:testcovers the decision paths with fake git, skopeo and podman results.Verification
bun testintools/agent-image-index: 13 pass. Cases covered::latestpaths: no newer index; newer index with a matching or a stale:latest; sha not on main; ambiguous registry error while walking.:gitguard: equal, different, manifest-unknown and other errors.:gitbefore:latest.:latestbefore the guard fails the order test.bunx tsc --noEmitandbiome check tools/agent-image-index: clean. actionlint findings match the parent commit's baseline.registry:2, with real skopeo and podman behind ref-rewriting shims::latestto the newer index.Risks
The first
mainrun exercises the new bootstrap and tool. A failure stops before:latestmoves or fails loudly afterwards; consumers keep the previous index. Rollback is a revert.Compatibility
No tag, registry or consumer change. Workflow-internal only.
Documentation
None: CI-internal refactor.
Refs RIG-4735