Fix Observable.take scheduler annotation - #8289
Merged
akarnokd merged 1 commit intoAug 19, 2026
Merged
Conversation
akarnokd
approved these changes
Aug 19, 2026
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.763 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8289 +/- ##
=========================================
Coverage 98.60% 98.61%
+ Complexity 7150 7149 -1
=========================================
Files 824 824
Lines 50791 50791
Branches 6911 6911
=========================================
+ Hits 50084 50088 +4
+ Misses 482 480 -2
+ Partials 225 223 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Observable.take(long, TimeUnit)fromNONEtoCOMPUTATIONtimer(time, unit)implementation, its Javadoc, and the equivalentFlowableoverloadFixes #8288
Validation
./gradlew test --tests "io.reactivex.rxjava4.validators.CheckBaseTypeAnnotationsTest" --tests "io.reactivex.rxjava4.validators.CheckJavadocForAnnotationsTest"./gradlew test --tests "io.reactivex.rxjava4.validators.*" --stacktrace --no-daemon./gradlew build --stacktrace./gradlew javadoc --stacktraceAI disclosure
This contribution was made with OpenAI Codex assistance. Codex inspected the current
4.ximplementation and contribution policy, applied the one-line annotation correction, and ran the validation listed above. The reasoning was that this overload delegates to the default computation-schedulertimer, its Javadoc already documents computation scheduling, and the equivalentFlowableoverload already usesSchedulerSupport.COMPUTATION.