Skip to content

all.equal.data.table: sub-aggregate before comparison - #7894

Draft
venom1204 wants to merge 1 commit into
masterfrom
issue7890
Draft

all.equal.data.table: sub-aggregate before comparison#7894
venom1204 wants to merge 1 commit into
masterfrom
issue7890

Conversation

@venom1204

@venom1204 venom1204 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

closes #7890

this pr adds by and fun.aggregate (defaulting to sum) arguments to all.equal.data.table.
this allows sub aggregation to align datasets at different levels of granularity before performing equality checks.

hi @tdhock @joshhwuu can you have a look when u got time , thanks

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (e26cf1b) to head (e75d652).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7894   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          88       88           
  Lines       17376    17381    +5     
=======================================
+ Hits        17206    17211    +5     
  Misses        170      170           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jangorecki

jangorecki commented Aug 28, 2026

Copy link
Copy Markdown
Member

I thought about implementing that after/together when rewriting all.equal.data.table completely to address #7816
I would rather keep this feature on hold, unless we decide not to rewrite all.equal.data.table.
Moreover this PR does not address many corner cases, few at the first glance: non-existing columns specified in by, empty by, column types to aggregate.fun not supported in specified aggregate.fun.

@venom1204

Copy link
Copy Markdown
Contributor Author

thanks for the feedback, @jangorecki. i understand the priority of the issue #7816 . i am happy to keep this on hold. if u want anything from my side am open to work ,thanks.

@jangorecki
jangorecki marked this pull request as draft August 28, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

all.equal could have option to sub-aggregate before comparison

2 participants