adding jar offset rewriting and capability to use custom preambles#29
Open
mbjarland wants to merge 7 commits intoRaynes:masterfrom
Open
adding jar offset rewriting and capability to use custom preambles#29mbjarland wants to merge 7 commits intoRaynes:masterfrom
mbjarland wants to merge 7 commits intoRaynes:masterfrom
Conversation
Author
|
Oh, and I fully expect that somebody will tell me this problem is already solved somehow. If so, great! I still learned quite a lot going through the process so time well spent. If not, perhaps I have done a small contribution that might save somebody else some time somewhere down the line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for this library. I have been looking for a way to do this for ages and this really solves the problem in an elegant and once-and-for-all way.
With that being said, the current state of this library still left me with two items missing from my wish list of perfection:
unzip -lon the resulting jar).I'm somewhat new to clojure and solving this problem led me down quite a journey. In (not so) short:
apologies for the rambling. It was some journey and I would like to thank the writers of this library for writing something so good that it was worth the above trouble to improve on.
If you deem this change acceptable, great. If not, this still solves my local problem so again, many thanks for this library.