This repository was archived by the owner on Nov 5, 2025. It is now read-only.
Conversation
* Ported CLI to argparse, based on OO programming paradigm * Added descriptive comments * Updated usage string * Added logging * Updated exmaples * Removed function based CLI code * Removed docopt dependency * Added usage constant * Added back the PVPN_WAIT environment variable * Addressed Flake8 issues * Examples are now inline with the CLI * Removed unncesessary comment * Cleaned up code and improved readability * Removed dependencies still they are no longer needed * Updated inline command * Allow uppercase protocol with -p * Allign help message * Return missing -p to example Co-authored-by: Alexandru Cheltuitor <31934100+calexandru2018@users.noreply.github.com>
Adding custom config option and a example how to run systemd with restart possibility.
Fix linting
Collaborator
|
Hey @mazhead Thanks for the contribution. The Linux clients are being rewriten, so the current MR probably will go to waste as the source code will be replaced. Thank you for your comprehension. |
Author
|
@calexandru2018 what is the estimate? If it is a near future then fine, but if it will be months, maybe you can consider merging. |
Collaborator
|
Hey @mazhead Unfortunately I can not provide a ETA atm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding custom config option and a example how to run systemd with restart possibility.
Related issue: https://github.com/ProtonVPN/linux-cli/issues/250