Skip to content

[fix] gd32: can: add IRQ aliases and init fixes for legacy series #11145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
illustriousness wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix] gd32: can: add IRQ aliases and init fixes for legacy series #11145

illustriousness wants to merge 1 commit into from
+47 −19

Conversation

@illustriousness
Copy link
Contributor

@illustriousness illustriousness commented Jan 21, 2026

  • add CAN0 IRQ alias macros for F10x/F30x/E50x
  • guard optional CAN1 IRQs
  • adjust RX pin mode and auto-retrans handling

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@illustriousness
[fix] gd32: can: add IRQ aliases and init fixes for legacy series
311d5bd 
  - add CAN0 IRQ alias macros for F10x/F30x/E50x
  - guard optional CAN1 IRQs
  - adjust RX pin mode and auto-retrans handling
@github-actions
Copy link

github-actions bot commented Jan 21, 2026

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：fix/gdcan
  • 设置PR number为 \ Set the PR number to：11145
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 fix/gdcan 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/gdcan branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added BSP BSP: GD32 BSP related with GD32 labels Jan 21, 2026
Rbb666
Rbb666 reviewed Jan 21, 2026
View reviewed changes
bsp/gd32/arm/libraries/gd32_drivers/drv_can.c
if (CAN1 == can_dev->can_x)
{
#if defined(CAN1_RX0_IRQn)
nvic_irq_enable(CAN1_RX0_IRQn, 1, 0);
Copy link
Member

@Rbb666 Rbb666 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看上面的CAN0修改成了 CAN0_RX0_IRQn_ALIAS，CAN1的这块是否也需要修正？
还是说这个MCU只有一路CAN？

Copy link
Contributor Author

@illustriousness illustriousness Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看上面的CAN0修改成了 CAN0_RX0_IRQn_ALIAS，CAN1的这块是否也需要修正？ 还是说这个MCU只有一路CAN？

can1 基本在CL型 中才有 我看pkg下 can1的中断名字都是这个
这个mcu中 只有一路can 不过库中有定义can1
更完善一下的话 可以把上面的ifdef CAN1 直接改成下面的#if defined(CAN1_RX0_IRQn)

Copy link
Contributor Author

@illustriousness illustriousness Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看上面的CAN0修改成了 ，CAN1的这块是否也需要修正？还是说这个MCU只有一路CAN？CAN0_RX0_IRQn_ALIAS

can1 基本在CL型 中才有 我看pkg下 can1的中断名字都是这个 这个mcu中 只有一路can 不过库中有定义can1 更完善一下的话 可以把上面的ifdef CAN1 直接改成下面的#if defid（CAN1_RX0_IRQn）

纠正一下 GDH7XX 的can1不符合CAN1_RX0_IRQn这样
image

@Rbb666
Copy link
Member

Rbb666 commented Jan 21, 2026

然后建议把驱动添加到ci看护中：

https://club.rt-thread.org/ask/article/5edd0f0940a57129.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Rbb666 left review comments

@kurisaW kurisaW Awaiting requested review from kurisaW kurisaW is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

BSP: GD32 BSP related with GD32 BSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@illustriousness @Rbb666