Skip to content

Conversation

@ThomasNing
Copy link
Contributor

@ThomasNing ThomasNing commented Jan 23, 2026

Proposed changes

This PR has two features:

  1. Solve the CTAD error issue in our new Rocm Compiler
  2. Help developers or AI Agents to awake the docker container to do different operations to test the code.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@illsilin illsilin merged commit 3900e1e into develop Jan 26, 2026
22 checks passed
@illsilin illsilin deleted the docker_script branch January 26, 2026 18:29
@afagaj afagaj requested a review from Copilot January 26, 2026 19:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a CTAD (Class Template Argument Deduction) regression and introduces comprehensive Docker management tools for Composable Kernel testing.

Changes:

  • Removed CTAD deduction guide from BlockReduce2D that was causing compilation issues
  • Fixed BlockSoftmax2D to explicitly specify template argument instead of relying on CTAD
  • Added a suite of shell scripts (ck-*) for Docker-based development workflow including build, test, status, and container management utilities
  • Removed trailing comment marker in mx_flatmm_pipeline_agmem_bgmem_creg_v1_policy.hpp

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
include/ck_tile/ops/reduce/block/block_reduce.hpp Removed CTAD deduction guide to resolve regression
include/ck_tile/ops/softmax/block/block_softmax_2d.hpp Added explicit template argument to fix CTAD-related compilation issue
include/ck_tile/ops/flatmm/pipeline/mx_flatmm_pipeline_agmem_bgmem_creg_v1_policy.hpp Cleaned up trailing comment marker
script/tools/ck-test New utility for building and running tests in Docker
script/tools/ck-stop New utility for stopping and removing Docker containers
script/tools/ck-status New utility for checking container status and information
script/tools/ck-start New utility for starting Docker containers
script/tools/ck-shell New utility for opening interactive shell sessions
script/tools/ck-logs New utility for viewing container and build logs
script/tools/ck-exec New utility for executing arbitrary commands in containers
script/tools/ck-clean New utility for cleaning build artifacts
script/tools/ck-build New utility for building Composable Kernel targets

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Common Commands:
ck-exec rocm-smi # Check GPU status
ck-exec rocminfo \| grep gfx # Check GPU architecture
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipe character should not be escaped in the comment. It should be '|' instead of '|'.

Suggested change
ck-exec rocminfo \| grep gfx # Check GPU architecture
ck-exec rocminfo | grep gfx # Check GPU architecture

Copilot uses AI. Check for mistakes.
@ThomasNing ThomasNing changed the title Solve the CTAD regression & add up the Shell file for the docker management in testing Solve the staging compiler regression and enhance the docker container execution in script/tools Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants