Move the apertures configurations to the agent#23
Open
ammallya wants to merge 2 commits intoamd-stagingfrom
Open
Move the apertures configurations to the agent#23ammallya wants to merge 2 commits intoamd-stagingfrom
ammallya wants to merge 2 commits intoamd-stagingfrom
Conversation
In a future change, to solve address space compatibility issues between device specific architectures and generic architectures, all address spaces will be made global. This future change will make it impossible to specialize the generic address spaces and hold architecture dependent apertures configurations. In order to determine the dependency of a generic segment address, we will now need to use agent. address_space_t::lower: This is were the conversion from a generic address space to a local or private_* address space using the agent specific apertures will be done. For now, just add the unused agent_t. amd_dbgapi_address_dependency: add a wave_id argument and validate it. Lower the segment address using the wave's agent, then call address_space_t::address_dependency. Notable change: reading/writing memory with amd_dbgapi_read_memory/ amd_dbgapi_write_memory now returns an INVALID_ARGUMENT_COMPATIBILITY error if the address space is the generic address space and the wave_id is WAVE_NONE. Prior to this change, the memory operation was executed if the generic segment address was a global address.
Since the apertures configurations are agent dependent, move the apertures configurations from the generic address space to the agent. Use the agent's os_info to set the memory regions.
Contributor
Author
|
@lmoriche_amdeng @lancesix_amdeng @shvahedi_amdeng can you please prioritize this for the first release ( around Feb/Mar) to early customers/ alongside bring up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.