feat: support push_asset_amount on RGB channel open#19
feat: support push_asset_amount on RGB channel open#19bitwalt wants to merge 1 commit intoRGB-Tools:rgbfrom
Conversation
bitwalt
force-pushed
the
feat/push-asset-amount-rln
branch
from
d55ff5f to
125b5ab
Compare
|
Thanks! I will review this ASAP, but please in the meantime do a self review and drop unnecessary changes (see |
bitwalt
force-pushed
the
feat/push-asset-amount-rln
branch
2 times, most recently
from
890fbd5 to
ee98355
Compare
zoedberg
left a comment
zoedberg
left a comment
There was a problem hiding this comment.
thanks, please address the requested changes
lightning/src/ln/channel.rs
Outdated
| /// The RGB asset amount to push to the counterparty on channel open. | ||
| pub(super) push_asset_amount: Option<u64>, |
There was a problem hiding this comment.
I think it would be better to move this to the FundingScope since it should be needed only during the funding phase. Same should be for consignment_endpoint, which I forgot to move when updating rust-lightning last time. Would you please move both?
There was a problem hiding this comment.
Ok, I kept only a derived is_colored flag in ChannelContext so the channel can retain that property without holding funding-only data there.
bitwalt
force-pushed
the
feat/push-asset-amount-rln
branch
from
ee98355 to
ea15124
Compare
|
Hi Zoe, thanks for the review. Requested changes should have been applied. |
2 participants
Implements #18