Fix QuantBook start/end date validation in research#9386
Open
aiSynergy37 wants to merge 1 commit intoQuantConnect:masterfrom
Open
Fix QuantBook start/end date validation in research#9386aiSynergy37 wants to merge 1 commit intoQuantConnect:masterfrom
aiSynergy37 wants to merge 1 commit intoQuantConnect:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What\n- add QuantBook-specific SetStartDate/SetEndDate wrappers that validate date bounds after each assignment\n- throw ArgumentException when EndDate < StartDate with the expected user-facing message\n- add regression tests for both DateTime and integer overloads\n\n## Why\nIssue #6593 reports that research notebooks accept incompatible start/end dates without raising an error. This can lead to confusing behavior when users configure date ranges in the wrong order.\n\n## How\n- hide the base date setter methods in QuantBook using
ew overloads and delegate to �ase setters\n- call a shared private validator after each setter to enforce a valid range\n- assert the exact exception message in QuantBookTests for both overload paths\n\nCloses #6593