Fix #8268: align PortfolioStatistics win/loss metric definitions#9385
Open
aiSynergy37 wants to merge 1 commit intoQuantConnect:masterfrom
Open
Fix #8268: align PortfolioStatistics win/loss metric definitions#9385aiSynergy37 wants to merge 1 commit intoQuantConnect:masterfrom
aiSynergy37 wants to merge 1 commit intoQuantConnect:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AverageWinRateAverageLossRateWinRateLossRatePerformanceMetrics,BacktestSummary, and supporting constructor/parameter docs).PortfolioStatisticsTeststhat demonstrates the intended behavior when transaction classification differs from signed profit/loss.Why
Issue #8268 points out a mismatch between the metric definitions and how PortfolioStatistics is actually computed. The implementation uses transaction record values and transaction classification counts, so the docs should reflect that behavior to avoid misleading users.
How
WinLossRatesCanDifferFromAverageRatesWhenUsingTransactionClassificationto verify:Testing
dotnet build Tests/QuantConnect.Tests.csproj --no-restore -p:NuGetAudit=false -p:TreatWarningsAsErrors=falsedotnet test Tests/QuantConnect.Tests.csproj --no-build --filter "Name=WinLossRatesCanDifferFromAverageRatesWhenUsingTransactionClassification"(test host crashes in this environment with Python.NET GIL finalizer error unrelated to these changes)Closes #8268