Add all tools as sub-indicators to SwissArmyKnife#9370
Open
0xpinara wants to merge 1 commit intoQuantConnect:masterfrom
Open
Add all tools as sub-indicators to SwissArmyKnife#93700xpinara wants to merge 1 commit intoQuantConnect:masterfrom
0xpinara wants to merge 1 commit intoQuantConnect:masterfrom
Conversation
Previously, each SwissArmyKnife instance could only compute a single tool. To use multiple tools, users had to create separate instances. Now all five tools (Gauss, Butter, HighPass, TwoPoleHighPass, BandPass) are computed simultaneously and exposed as public properties. Resolves QuantConnect#3270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored
SwissArmyKnifeto compute all fiveSwissArmyKnifeToolvalues simultaneously. Each tool is now exposed as a public sub-indicator property (Gauss,Butter,HighPass,TwoPoleHighPass,BandPass), so users no longer need to create separate instances per tool.The selected
toolparameter still determinesCurrent.Valuefor backward compatibility.Related Issue
Resolves #3270
Motivation and Context
If a user wanted multiple Swiss Army Knife tools, they had to create one indicator per tool. This refactoring lets a single instance compute all tools at once.
Requires Documentation Change
No
How Has This Been Tested?
SubIndicatorsComputeAllToolsSimultaneously— verifies each sub-indicator matches a standalone instanceSubIndicatorsResetProperly— verifies all sub-indicators reset afterReset()PrimaryToolMatchesCurrentValue— verifiesCurrent.Valueequals the selected tool's sub-indicator for every tool typeTypes of changes
Checklist
feature-3270-add-all-tools-to-swiss-army-knife