fix: Prevent crashes from `View.refresh` by NeloBlivion · Pull Request #3059 · Pycord-Development/pycord

NeloBlivion · 2026-01-07T06:13:21Z

Summary

Pycord currently has an issue with race conditions in views - sometimes when editing a message or interaction response, the gateway will receive said message's MESSAGE_UPDATE from Discord and attempt to internally refresh the view before ViewStore has updated.

Traceback (most recent call last):
...
  File "/.../lib/python3.12/site-packages/discord/state.py", line 795, in parse_message_update
    self._view_store.update_from_message(raw.message_id, data["components"])
  File "/.../lib/python3.12/site-packages/discord/ui/view.py", line 807, in update_from_message
    view.refresh(components)
  File "/.../lib/python3.12/site-packages/discord/ui/view.py", line 610, in refresh
    item.refresh_component(c)
  File "/.../lib/python3.12/site-packages/discord/ui/container.py", line 371, in refresh_component
    x.refresh_component(y)
  File "/.../lib/python3.12/site-packages/discord/ui/section.py", line 268, in refresh_component
    for x, y in zip(self.items, component.components):
                                ^^^^^^^^^^^^^^^^^^^^
AttributeError: 'TextDisplay' object has no attribute 'components'
# The client received a TextDisplay where it was expecting a Section, because that was the structure of the OLD view.

This is meant to be circumvented through remove_message_tracking, but this is not possible in response edit scenarios where the library may not have knowledge of the relevant message_id beforehand.

This PR:

Attempts to refresh using the internal _original_response that's now returned from all interactions
If the refresh fails, be less distruptive with logging.warning
Renames refresh to reduce likelihood of being overridden by users

I'm not certain if the first change is entirely appropriate - if this happens to target the wrong message, I will instead revert that specfic change.

Information

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.

pycord-app · 2026-01-07T06:13:24Z

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3059/head:pr-3059
git checkout pr-3059

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3059/head

Paillat-dev

(I am nitpicking, pr lgtm di per se)

Paillat-dev · 2026-01-08T17:16:02Z

discord/ui/view.py

+        try:
+            view._refresh(components)
+        except:
+            _log.warning(


I'm not sure here whether we should prefer _log.warning or _log.exception - with the reasoning behind this being that this potentially removes from existence useful traceback info in case someone encounters this when they should not.

Alternatively we maybe could add a _log.debug with exc_info=True as well or something ? Idk just an idea.

Paillat-dev · 2026-01-08T17:17:09Z

discord/interactions.py

        )
-        if view and self.message:
-            self._state.prevent_view_updates_for(self.message.id)
+        _message = self.message or self._original_response


Maybe call it something different, like target, would be less confusing.

Paillat-dev · 2026-01-08T17:18:09Z

Oh and changelog

Paillat-dev · 2026-01-25T18:14:48Z

discord/ui/modal.py

        return self

-    def refresh(self, interaction: Interaction, data: list[ComponentPayload]):
+    def _refresh(self, interaction: Interaction, data: list[ComponentPayload]):


I'd add an overrideable alias from refresh to _refresh with a deprecation warning, although it's not strictly necessary, I'm sure some people used this method for whatever reason, and while it wasn't documented, it was in fact private.

Because it wasn't documented I don't think a deprecation warning is necessary.

Paillat-dev · 2026-01-25T18:42:52Z

@Lumabots Can you run your test bot on this pr for some time or something like that ?

Lumabots · 2026-01-25T18:44:27Z

@Lumabots Can you run your test bot on this pr for some time or something like that ?

yep
after 12h no crashs or nothing restart, disconnection reconnection etc and no error to report

Paillat-dev · 2026-01-26T22:43:42Z

@Lumabots You tested using views and stuff ?

Lumabots · 2026-01-27T05:50:27Z

@Lumabots You tested using views and stuff ?

Yep, using view, timeout, persistent view replace item add item remove item etc

Paillat-dev · 2026-01-31T14:59:16Z

In case you missed it @NeloBlivion I left a couple comments here

Dorukyum · 2026-02-06T07:17:17Z

discord/ui/modal.py

        return self

-    def refresh(self, interaction: Interaction, data: list[ComponentPayload]):
+    def _refresh(self, interaction: Interaction, data: list[ComponentPayload]):


Because it wasn't documented I don't think a deprecation warning is necessary.

Dorukyum · 2026-02-06T07:19:26Z

discord/interactions.py

+        _message = self.message or self._original_response
+        if view and _message:
+            self._state.prevent_view_updates_for(_message.id)


I agree with Paillat

Suggested change

_message = self.message or self._original_response

if view and _message:

self._state.prevent_view_updates_for(_message.id)

_target = self.message or self._original_response

if view and _target:

self._state.prevent_view_updates_for(_target.id)

NeloBlivion added 3 commits January 7, 2026 00:46

attempt view refresh fix

d1bb478

rename to _refresh

ed6b6e0

_message

850edd6

NeloBlivion requested a review from a team as a code owner January 7, 2026 06:13

pullapprove4 bot added the PA: All Contributors pending label Jan 7, 2026

style(pre-commit): auto fixes from pre-commit.com hooks

242909d

Paillat-dev added this to the v2.7.1 milestone Jan 7, 2026

Paillat-dev added hold: testing This pull request requires further testing components Related to discord components (Views + Modals) labels Jan 7, 2026

Paillat-dev self-requested a review January 7, 2026 10:38

Paillat-dev added the hold: changelog This pull request is missing a changelog entry label Jan 7, 2026

Paillat-dev reviewed Jan 8, 2026

View reviewed changes

Paillat-dev requested review from JustaSqu1d, Soheab and plun1331 January 25, 2026 18:10

Paillat-dev reviewed Jan 25, 2026

View reviewed changes

Paillat-dev requested a review from Lumabots January 25, 2026 18:42

Merge branch 'master' into view_refresh

da17564

Dorukyum requested changes Feb 6, 2026

View reviewed changes

pullapprove4 bot removed the PA: All Contributors pending label Feb 6, 2026

Uh oh!

Conversation

NeloBlivion commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Information

Checklist

Uh oh!

pycord-app bot commented Jan 7, 2026

Uh oh!

Paillat-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Paillat-dev Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Paillat-dev Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Paillat-dev commented Jan 8, 2026

Uh oh!

Paillat-dev Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

Dorukyum Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Paillat-dev commented Jan 25, 2026

Uh oh!

Lumabots commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Paillat-dev commented Jan 26, 2026

Uh oh!

Lumabots commented Jan 27, 2026

Uh oh!

Paillat-dev commented Jan 31, 2026

Uh oh!

Dorukyum Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Dorukyum Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NeloBlivion commented Jan 7, 2026 •

edited

Loading

Lumabots commented Jan 25, 2026 •

edited

Loading