Add missing error handling for PyModule_FromSlotsAndSpec#5915
Merged
Add missing error handling for PyModule_FromSlotsAndSpec#5915
PyModule_FromSlotsAndSpec#5915Conversation
Tpt
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we call
PyModule_SetDocStringwithout doing any error handling on the result ofPyModule_FromSlotsAndSpec. It had been a while since I wrote code dealing with raw FFI pointers when I wrote this and then it got missed in review during review of #5753. I don't think there are any other raw FFI calls where I made a similar mistake in that PR.