deprecate reconnect parameter of ping()#790
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
==========================================
+ Coverage 88.86% 90.28% +1.41%
==========================================
Files 7 7
Lines 548 556 +8
==========================================
+ Hits 487 502 +15
+ Misses 61 54 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR deprecates the reconnect parameter of Connection.ping() by emitting a DeprecationWarning when callers pass the argument, and adds a regression test to ensure the warning is raised.
Changes:
- Emit
DeprecationWarningwhenping(reconnect=...)is used. - Update
ping()docstring to describe the deprecation. - Add a test asserting
conn.ping(False)warns.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_connection.py | Adds a test expecting a deprecation warning when ping(False) is called. |
| src/MySQLdb/_mysql.c | Implements the deprecation warning and updates the ping() docstring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+33
to
+36
| conn = connection_factory() | ||
| with pytest.warns(DeprecationWarning, match="reconnect parameter"): | ||
| conn.ping(False) | ||
| conn.close() |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.