Fixed faulty python function parameter parsing#28
Merged
chengpeng-wang merged 3 commits intoPurCL:mainfrom Mar 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python_TS_Analyzer.py, the function get_parameters_in_single_function() only checks nodes with the type "identifier" when finding parameters. Since identifier nodes are also present within type annotations, this fault would cause type annotations to be mistakenly interpreted as a separate parameter.
The fix added a new condition to check if the parent of an identifier node (if it exist) has type "type", If so, the identifier node would be ignored.