Fix DFPlayer test to fail cleanly when hardware is missing#355
Open
Fix DFPlayer test to fail cleanly when hardware is missing#355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was fixed
DFPlayer test no longer hangs when the module is absent or unresponsive
SD test now fails cleanly if DFPlayer is not present
Speaker test is gated on both DFPlayer presence and readable SD files
Centralized DFPlayer initialization and response checks
Removed dead and unreachable code paths in DFPlayer, SD, Speaker, SPI, and RS-232 tests
Run-All sequence remains linear and non-blocking
Expected behavior after this change
Firmware continues running even on incomplete hardware
Missing DFPlayer hardware is reported correctly as FAIL
No false “DFPlayer detected” messages
No blocking waits or infinite loops