feat: detect revoked GitHub token and prompt re-authentication#1920
Open
Subhra-Nandi wants to merge 1 commit into
Open
feat: detect revoked GitHub token and prompt re-authentication#1920Subhra-Nandi wants to merge 1 commit into
Subhra-Nandi wants to merge 1 commit into
Conversation
- Add TokenRevoked to AUTH_ERROR_MESSAGES in signin page showing 'Your GitHub access was revoked. Please sign in again to continue.' - Add TokenRevokedGuard client component that watches session.error and calls signOut() redirecting to /auth/signin?error=TokenRevoked - Mount TokenRevokedGuard in dashboard page - Install rehype-sanitize (missing dep, unrelated to this feature) The jwt callback in auth.ts already sets token.error = 'TokenRevoked' when GET /user returns 401. This PR completes the user-facing side. Closes Priyanshu-byte-coder#884
|
@Subhra-Nandi is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Owner
|
CI is failing because this branch is based on an older version of Please rebase on git fetch origin
git rebase origin/main
git push --force-with-lease |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #884
The JWT callback in
auth.tsalready validates the stored token every 24hand sets
session.error = "TokenRevoked"when GitHub returns 401. This PRcompletes the user-facing side — detecting that flag and redirecting the user
to sign in with a clear message instead of silently showing empty widgets.
Changes
src/app/auth/signin/page.tsxTokenRevokedtoAUTH_ERROR_MESSAGESsrc/components/TokenRevokedGuard.tsxsrc/app/dashboard/page.tsxTokenRevokedGuardpackage.jsonrehype-sanitizedependencyHow It Works
jwtcallback hitsGET /api.github.com/user→ gets 401token.error = "TokenRevoked"is set on the JWTsession.error = "TokenRevoked"is surfaced to the clientTokenRevokedGuarddetects this and callssignOut({ callbackUrl: "/auth/signin?error=TokenRevoked" })What Was Already There (untouched)
auth.ts— full token validation logic ✅next-auth.d.ts— types forsession.error✅error-utils.ts— safe error message string ✅wrapped/page.tsx— already handlesTokenRevoked✅Screenshots