feat: zone base double tap gesture & reduce boilerplate #98
Open
B-2U wants to merge 2 commits into
Open
Conversation
…ay, right=seek forward - zone-based double-tap gesture: left=seek back, middle=pause/play, right=seek forward - show seek duration in the center of the screen when double-tapping - add slider in player settings to configure double-tap seek duration (5/10/15/20s)
All gesture handlers (drag, scroll, long-press, double-tap) now use the unified widget to show feedback.
Author
|
才發現還有 https://github.com/Predidit/Kazumi 的存在,感覺自己像小丑🤡 |
Owner
|
这个仓库不会被 repo ,我会继续维护这个仓库但是不会主动添加新功能并欢迎 PR 这个仓库的定位是一个极简的第三方客户端,和 Kazumi 不同 你想把PR落地在哪里呢 |
原來如此 了解了
這個PR應該還是給OneAnime合適,看起來Kazumi的播放器是模仿B站的操作風格(全畫面雙擊暫停/播放),我覺得那邊不需要特別加上這個變化,不過我還是有在那邊提一個可關閉音量/亮度控制的PR Predidit/Kazumi#2030 ,有機會再請您過目一下,謝謝! |
Author
|
才發現昨天回覆時切錯賬戶了😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原本android上onDoubleTap會直接觸發
_handleShortSeek(),現在將螢幕按橫坐標切為三等分,左右側快進快退固定秒數,中間播放/暫停,並在設置中加入滑條,調整上方提到的秒數重構並統一播放器中的各種行為(加速、快進/退、調整音量/亮度)使用的通知氣泡,減少重複性代碼