Repository navigation
Fix wrapped configuration parameters in DSC server - #1739
Merged
Steve Lee (SteveL-MSFT) merged 4 commits intoOct 7, 2026
Merged
Steve Lee (SteveL-MSFT) merged 4 commits into
Steve Lee (SteveL-MSFT) merged 4 commits into
Conversation
Accept JSON and YAML parameters with or without the top-level parameters wrapper, preserving parameter-file value syntax. Add regression coverage and document supported input formats. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Fixes #1738 |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Bare parameters named parameters can be incorrectly interpreted as wrapper objects.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds support for bare and wrapped JSON/YAML configuration parameters in the DSC MCP server.
Changes:
- Detects wrapped parameter input.
- Adds regression coverage for supported formats.
- Documents parameter syntax.
| File | Description |
|---|---|
dsc/src/server/invoke_dsc_config.rs |
Normalizes parameter input. |
dsc/tests/dsc_server.tests.ps1 |
Tests bare, wrapped, and value-wrapped forms. |
docs/concepts/dsc-mcp-server.md |
Documents supported formats. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Steve Lee (SteveL-MSFT)
approved these changes
Oct 7, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Steve Lee (SteveL-MSFT)
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept JSON and YAML parameters with or without the top-level parameters wrapper, preserving parameter-file value syntax. Add regression coverage and document supported input formats.
PR Summary
PR Context