feat: automate Rust debug-symbol upload in upload-source-maps - #938
Merged
Conversation
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
cat-ph
force-pushed
the
cat/upload-source-maps-rust
branch
from
July 27, 2026 18:00
d29cb6d to
6600e80
Compare
cat-ph
force-pushed
the
cat/upload-source-maps-rust
branch
from
July 29, 2026 13:08
d4d491e to
58185e2
Compare
cat-ph
marked this pull request as ready for review
July 29, 2026 15:54
hpouillot
approved these changes
Jul 30, 2026
ablaszkiewicz
approved these changes
Jul 30, 2026
cat-ph
enabled auto-merge (squash)
July 30, 2026 20:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Adds Rust support to the
upload-source-mapsprogram, mirroring the Android/iOS pattern:rustjoinsAUTOMATABLE_VARIANTSandVARIANTS_REQUIRING_POSTHOG_CLI(the upload shells out to a PATHposthog-cli symbol-sets upload, so the wizard pre-installs it).gois recognized-but-blocked (like react-native/flutter): the picker names Go projects and shows "not supported yet" instead of letting them fall through to thewebvariant. It flips to automatable when posthog-go ships its native-frames release.go/rustrank after every JS target but ahead of thewebfallback, so a native project with a tooling-onlypackage.jsonresolves correctly.hasPostHogfor rust: the agent reports one boolean for any PostHog dependency in a project, which a stray JS SDK could satisfy — a comment-stripped read of the project's Cargo manifests forposthog-rsis authoritative instead. When the project manifest misses (a workspace root is often a virtual manifest with no[dependencies]), a bounded walk checks member manifests — caught by devbox testing against therust-workspacefixture, which previously reported "missing the PostHog SDK" for the root selection.Warning
Merge gate: STEP 2 installs
error-tracking-upload-source-maps-rust, which ships with context-mill PR #262 — release that first or every Rust run fails withERROR_RESOURCE_MISSING. Old wizards are unaffected by the skill releasing first (they never resolve arustvariant).Tests: full suite green (113 files / 1534+ tests), new coverage for target precedence, rust retained/blocked classification, go blocked classification, and the Cargo verifier (commented-out dep ignored, renamed dep accepted).
Review notes (codex, 2 rounds): fixed comment-stripped Cargo matching. Rejected: full TOML/workspace-inheritance parsing for the picker hint (documented looseness; the skill agent owns workspace mechanics — a workspace profile/target gotcha was added to the skill in #262 instead), and gating rust on the local OS for the Windows-PDB gap (production builds usually run on Linux CI regardless of the dev's OS).
🤖 Generated with Claude Code