chore(self-driving): cut the comments I added down to one line each - #1032
Merged
gewenyu99 merged 1 commit intoJul 29, 2026
Merged
Conversation
Seven multi-line comment blocks from #1028 and #1031 collapsed to a single line each. Net -71 lines, no behaviour change. The rationale that was in them belongs in the PR descriptions, which already carry it: why the key is self-driving's own rather than the warehouse program's, how the promoted list was computed, and why the count tag fires at zero and at -1. Generated-By: PostHog Code Task-Id: df870021-4bdf-465b-ba4f-d486c37b97d3
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
gewenyu99
merged commit Jul 29, 2026
04b1770
into
tom/self-driving-detected-sources
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The comments I added in #1028 and #1031 ran to multi-line rationale blocks — a six-line explanation on
prepareRunSession, an eighteen-line one on the promoted-tools constant. Vincent wants comments kept to one line.Changes
Seven blocks collapsed to a single line each across three files. Net −71 lines, no behaviour change.
The reasoning that was in them lives in the PR descriptions, which already carry it: why the key is self-driving's own rather than the warehouse program's, how the promoted list was computed, and why the count tag fires at zero and at −1.
Test plan
pnpm build && pnpm test && pnpm fix— 1671 tests pass, 0 lint errors. Comment-only.Created with PostHog Code