-
Notifications
You must be signed in to change notification settings - Fork 81
chore(mcp): enable model capture and conversation correlation by default #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lucasheriques
wants to merge
2
commits into
main
Choose a base branch
from
codex/mcp-analytics-defaults
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| pypi/posthog: minor | ||
| --- | ||
|
|
||
| Enable MCP model capture and conversation correlation by default, including on fresh low-level servers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| """Resolve model argument ownership on low-level servers without a tool registry.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import asyncio | ||
| from typing import Any, Awaitable, Callable, Optional | ||
|
|
||
| from ._internal import MCPAnalyticsData | ||
| from ._model_parameters import can_inject_model_parameter, is_capture_model_enabled | ||
| from .logger import log | ||
|
|
||
|
|
||
| async def resolve_model_ownership( | ||
| data: MCPAnalyticsData, | ||
| name: str, | ||
| list_page: Callable[[Optional[str]], Awaitable[Any]], | ||
| ) -> bool: | ||
| if not is_capture_model_enabled(data.options.capture_model): | ||
| return False | ||
| if name in data.tool_model_parameter_injected: | ||
| return data.tool_model_parameter_injected[name] | ||
| try: | ||
| return await asyncio.wait_for( | ||
| _find_model_ownership(name, list_page), timeout=0.25 | ||
| ) | ||
| except Exception: # noqa: BLE001 - discovery must not prevent tool dispatch | ||
| log( | ||
| "Warning: Could not resolve model argument ownership; leaving tool arguments unchanged." | ||
| ) | ||
| return False | ||
|
|
||
|
|
||
| async def _find_model_ownership( | ||
| name: str, list_page: Callable[[Optional[str]], Awaitable[Any]] | ||
| ) -> bool: | ||
| cursor = None | ||
| seen = set() | ||
| for _ in range(16): | ||
| response = await list_page(cursor) | ||
| result = getattr(response, "root", response) | ||
| ownership = _model_ownership(result, name) | ||
| if ownership is not None: | ||
| return ownership | ||
| cursor = _next_cursor(result) | ||
| if cursor is None or cursor in seen: | ||
| return False | ||
| seen.add(cursor) | ||
| return False | ||
|
|
||
|
|
||
| def _model_ownership(result: Any, name: str) -> Optional[bool]: | ||
| for tool in getattr(result, "tools", []): | ||
| if getattr(tool, "name", None) == name: | ||
| schema = getattr(tool, "input_schema", None) | ||
| if schema is None: | ||
| schema = getattr(tool, "inputSchema", None) | ||
| return can_inject_model_parameter(schema) | ||
| return None | ||
|
|
||
|
|
||
| def _next_cursor(result: Any) -> Optional[str]: | ||
| if hasattr(result, "next_cursor"): | ||
| cursor = result.next_cursor | ||
| else: | ||
| cursor = getattr(result, "nextCursor", None) | ||
| if not isinstance(cursor, str): | ||
| return None | ||
| return cursor or None | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fallback returns the resolved ownership without storing it. On a cold low-level server, each direct tool call therefore invokes the original
tools/listhandler again, potentially traversing 16 pages, repeating handler side effects, and adding up to 250 ms of latency. Cache the result indata.tool_model_parameter_injectedbefore returning it.Knowledge Base Used:
Prompt To Fix With AI