chore(metadata): remove the dead aurora metadata-store backend#675
Merged
Conversation
The "aurora" metadata-store backend (a per-org Aurora serverless-v2 cluster the composition stood up) is no longer provisionable and has no live deployments. cnpg-shard and external are the only backends. Rip it out completely — no backward-compat shim, no retained constant (same approach as the s3_tables removal in #648). Production: - configstore: drop MetadataStoreKindAurora, ManagedWarehouse.AuroraMin/MaxACU (+ the Config snapshot copy), and the aurora_min_acu/max_acu admin upsert cols - provisioning API: drop the "aurora" request shape (provisionAuroraReq) and the provisioning case; the type list now rejects anything but cnpg-shard/external - provisioner: drop CreateOptions.Min/MaxACU + the aurora Create arm (empty metadata-store kind now rejects instead of aliasing to aurora); drop the ACU wiring in the controller - reword stale aurora prose in kept paths (DuckLake coupling, probe rationale, lakekeeper inputs, CR doc) to "external"/"RDS"; preserve genuine AWS-Aurora engine refs (pg_stat_activity / Performance Insights observability, the networkpolicy egress to RDS/Aurora endpoints, metadata_probe TLS/DNS) Tests / seeds: - replace the two aurora provisioning tests with one asserting aurora is rejected (400, no warehouse created) - rewrite the shared controller_test fixtures (probe / pgbouncer-drift / endpoint / Synced) from aurora to external — they exercise backend-agnostic logic, so only the fixture type changes - drop aurora_min_acu/max_acu columns + values from the kind and tenant-isolation config-store seeds (struct fields gone → a fresh AutoMigrate won't create them, so the INSERTs must not reference them) go build / vet (-tags kubernetes) clean; provisioner + provisioning unit lanes green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
aurorametadata-store backend completely — the per-org Aurora serverless-v2 cluster path the composition used to stand up. It's no longer provisionable and has no live deployments, so this is a full rip-out: no backward-compat shim, no retained constant (same approach as thes3_tablesremoval in #648).cnpg-shardandexternalremain the only metadata backends.Disambiguation
"Aurora" appears in two senses; only the first is removed:
externalbackend — preserved (pg_stat_activity / Performance Insights observability comments, the networkpolicy egress to RDS/Aurora endpoints, the metadata-probe TLS/DNS rationale). Stale backend-prose mentioning "aurora" in kept paths was reworded toexternal/RDS.Production
MetadataStoreKindAurora,ManagedWarehouse.AuroraMin/MaxACU(+ the Config snapshot copy), and theaurora_min_acu/max_acuadmin upsert columns.aurorarequest shape (provisionAuroraReq) + its provisioning case; the type list now rejects anything but cnpg-shard/external.CreateOptions.Min/MaxACU+ the aurora Create arm. Behavior change: an emptymetadata_store_kindpreviously aliased to aurora — it now hits the rejectdefault:(intentional; no empty-kind rows exist). cnpg-shard/external are explicit cases, unaffected.Tests / seeds
controller_testfixtures (probe / pgbouncer-drift / endpoint / Synced) from aurora → external — they exercise backend-agnostic logic, so only the fixture type changes (coverage preserved, not deleted).aurora_min_acu/max_acucolumns + values from the kind and tenant-isolation config-store seeds — the struct fields are gone, so a fresh AutoMigrate won't create the columns and the INSERTs must not reference them.Verification
go build/go vet(-tags kubernetes) clean; provisioner + provisioning unit lanes green locally. CI covers the configstore-integration lane (seeds) + the e2e-mw-dev real-cluster run (cnpg + external activation still work, lakekeeper-only iceberg).