fix(wizard): Whack a mole part 4: align init token rule with the commandments' no-env exception - #290
Open
gewenyu99 wants to merge 2 commits into
Open
fix(wizard): Whack a mole part 4: align init token rule with the commandments' no-env exception#290gewenyu99 wants to merge 2 commits into
gewenyu99 wants to merge 2 commits into
Conversation
… no-env exception Both Swift runs independently flagged the contradiction: the commandments require embedding the real public token when a build has no environment to read (iOS/Android release/archive), while the init skill said "never hardcoded" without exception. State the same carve-out in the skill. Generated-By: PostHog Code Task-Id: affdea28-7761-4d50-8335-6b32376b1a82
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
gewenyu99
commented
Jul 29, 2026
gewenyu99
marked this pull request as ready for review
July 29, 2026 14:27
sarahxsanders
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
State the commandments' no-environment token carve-out in the integration-v2 init skill — both Swift runs independently hit the contradiction.
Generally mobile apps will just have these in a giant config file. Because environment variables are so strangely handled and Swift doesn't allow possibly undefined strings, we can either:
Just stick it in as a constant
default to '' and fail silently
It seems better to just stick it in as a constant
Created with PostHog Code