Skip to content

feat(notifications): add MSN Messenger completion sound #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trunk-io merged 1 commit into from
Jul 21, 2026
Merged

feat(notifications): add MSN Messenger completion sound #3605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added packages/ui/src/assets/sounds/msn.mp3
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions packages/ui/src/features/settings/sections/NotificationsSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ export function NotificationsSettings() {
<Select.Item value="switch">Switch</Select.Item>
<Select.Item value="wilhelm">Wilhelm scream</Select.Item>
<Select.Item value="icq">ICQ</Select.Item>
<Select.Item value="msn">MSN Messenger</Select.Item>
{customSounds.length > 0 && (
<Select.Group>
<Select.Label>Custom</Select.Label>
Expand Down
3 changes: 2 additions & 1 deletion packages/ui/src/features/settings/settingsStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ export type BuiltInCompletionSound =
| "slide"
| "switch"
| "wilhelm"
| "icq";
| "icq"
| "msn";

// A user-installed sound is selected by referencing its id as `custom:<id>`.
export type CompletionSound =
Expand Down
2 changes: 2 additions & 0 deletions packages/ui/src/utils/sounds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import icqUrl from "../assets/sounds/icq.mp3";
import knockUrl from "../assets/sounds/knock.mp3";
import meepUrl from "../assets/sounds/meep.mp3";
import meepSmolUrl from "../assets/sounds/meep-smol.mp3";
import msnUrl from "../assets/sounds/msn.mp3";
import reviUrl from "../assets/sounds/revi.mp3";
import ringUrl from "../assets/sounds/ring.mp3";
import shootUrl from "../assets/sounds/shoot.mp3";
Expand All @@ -35,6 +36,7 @@ const SOUND_URLS: Record<Exclude<BuiltInCompletionSound, "none">, string> = {
switch: switchUrl,
wilhelm: wilhelmUrl,
icq: icqUrl,
msn: msnUrl,
};

const MIN_RATE = 1 / 3;
Expand Down
Loading