Skip to content

feat(cloud): expose steering controls for cloud sessions#3541

Open
tatoalo wants to merge 1 commit into
posthog-code/cloud-steering-resume-hydrationfrom
posthog-code/cloud-steering-session-controls
Open

feat(cloud): expose steering controls for cloud sessions#3541
tatoalo wants to merge 1 commit into
posthog-code/cloud-steering-resume-hydrationfrom
posthog-code/cloud-steering-session-controls

Conversation

@tatoalo

@tatoalo tatoalo commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Problem

Cloud sessions do not expose the steering controls available to negotiated native runs.

Changes

Enables cloud Steer/Queue controls and shortcuts when native steering is supported.

tatoalo commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 440714c.

@tatoalo tatoalo self-assigned this Jul 17, 2026
@tatoalo
tatoalo force-pushed the posthog-code/cloud-steering-resume-hydration branch from a03ac79 to 0803ee1 Compare July 17, 2026 13:55
@tatoalo
tatoalo force-pushed the posthog-code/cloud-steering-session-controls branch from 2a07cc0 to d82cc2b Compare July 17, 2026 13:55
@tatoalo
tatoalo force-pushed the posthog-code/cloud-steering-resume-hydration branch from 0803ee1 to 15691d8 Compare July 17, 2026 14:06
@tatoalo
tatoalo force-pushed the posthog-code/cloud-steering-session-controls branch from d82cc2b to 80d300e Compare July 17, 2026 14:06
@tatoalo
tatoalo marked this pull request as ready for review July 17, 2026 14:49
@tatoalo
tatoalo force-pushed the posthog-code/cloud-steering-resume-hydration branch from 15691d8 to a061e3d Compare July 20, 2026 08:16
@tatoalo
tatoalo force-pushed the posthog-code/cloud-steering-session-controls branch from 80d300e to db15832 Compare July 20, 2026 08:16
@posthog

posthog Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

👋 Visual changes detected for this PR.

Review and approve in PostHog Visual Review

If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix.

@tatoalo
tatoalo force-pushed the posthog-code/cloud-steering-resume-hydration branch from a061e3d to 1543dca Compare July 20, 2026 14:46
@tatoalo
tatoalo force-pushed the posthog-code/cloud-steering-session-controls branch from db15832 to 440714c Compare July 20, 2026 14:46
@tatoalo
tatoalo requested a review from a team July 20, 2026 14:52
@tatoalo tatoalo added the Stamphog This will request an autostamp by stamphog on small changes label Jul 20, 2026

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new cloud native-steer code path is dead code: sessionSupportsNativeSteer in @posthog/shared/src/sessions.ts hard-returns false for any session where isCloud === true (line 234), so the new if (session.isCloud) { return sendCloudPrompt(..., { steer: true }) } block inside if (sessionSupportsNativeSteer(session)) can never be reached. The accompanying test "sends a native cloud steer immediately" would also fail in CI for the same reason — the expected steer: true param is never sent.

@stamphog stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant