feat(cloud): expose steering controls for cloud sessions#3541
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
a03ac79 to
0803ee1
Compare
2a07cc0 to
d82cc2b
Compare
0803ee1 to
15691d8
Compare
d82cc2b to
80d300e
Compare
15691d8 to
a061e3d
Compare
80d300e to
db15832
Compare
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
a061e3d to
1543dca
Compare
db15832 to
440714c
Compare
There was a problem hiding this comment.
The new cloud native-steer code path is dead code: sessionSupportsNativeSteer in @posthog/shared/src/sessions.ts hard-returns false for any session where isCloud === true (line 234), so the new if (session.isCloud) { return sendCloudPrompt(..., { steer: true }) } block inside if (sessionSupportsNativeSteer(session)) can never be reached. The accompanying test "sends a native cloud steer immediately" would also fail in CI for the same reason — the expected steer: true param is never sent.

Problem
Cloud sessions do not expose the steering controls available to negotiated native runs.
Changes
Enables cloud Steer/Queue controls and shortcuts when native steering is supported.