Make questionnaire cards vertically resizable#3536
Draft
luke-belton wants to merge 1 commit into
Draft
Conversation
Adds a drag handle to the top edge of the question permission card so users can shrink it to read more of the transcript above before answering, then grow it back (capped at 80vh). Inner content scrolls within the chosen height. Implemented as an opt-in `resizable` prop on the shared ActionSelector primitive, enabled by QuestionPermission. Generated-By: PostHog Code Task-Id: 6b270274-048e-4383-b258-62703ac84b9a
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Questionnaires (the interactive question cards shown for tool-call answering) sit at the bottom of the chat and can take up a lot of vertical space, leaving little room to read the conversation context above them without a lot of scrolling. Raised as feedback in Slack.
Changes
resizableprop to the sharedActionSelectorprimitive. When enabled, a drag handle rides the top edge of the card: dragging down shrinks it (revealing more of the transcript above), dragging up grows it back, clamped between a sensible floor and 80vh. The card's inner region scrolls within the chosen height, so the options and submit row stay visible.QuestionPermissionso it applies to questionnaires.How did you test this?
pnpm --filter @posthog/ui typecheck— passes.biome linton the changed files — clean.Automatic notifications
Created with PostHog from a Slack thread