Item prices by anhthang · Pull Request #1431 · PokeAPI/pokeapi

anhthang · 2026-03-07T16:21:06Z

Add ItemPrice model and exposes per-version item pricing data

Populate item prices from a new CSV source: ‎data/v2/csv/item_prices.csv
Remove the old ‎Item.cost field in favor of the new structured pricing model.
Add currency API

Example REST API response

GET /api/v2/item/305/

{
    "id": 305,
    "name": "some-item-name",
    "fling_power": null,
    "fling_effect": null,
    "category": {
        "name": "held-items"
    },
    "prices": [
        {
            "currency": {
                "name": "poke-dollar",
                "url": "http://localhost:8000/api/v2/currency/1/"
            },
            "purchase_price": 3000,
            "sell_price": 1500,
            "version_group": {
                "name": "red-blue",
                "url": "http://localhost:8000/api/v2/version-group/1/"
            }
        },
        {
            "currency": {
                "name": "poke-dollar",
                "url": "http://localhost:8000/api/v2/currency/1/"
            },
            "purchase_price": 3000,
            "sell_price": 1500,
            "version_group": {
                "name": "yellow",
                "url": "http://localhost:8000/api/v2/version-group/2/"
            }
        },
        {
            "currency": {
                "name": "poke-dollar",
                "url": "http://localhost:8000/api/v2/currency/1/"
            },
            "purchase_price": null,
            "sell_price": 1500,
            "version_group": {
                "name": "gold-silver",
                "url": "http://localhost:8000/api/v2/version-group/3/"
            }
        }
    ]
}

Example GraphQL queries

v1beta: item with prices

query ItemWithPrices {
  pokemon_v2_item_by_pk(id: 305) {
    id
    name
    pokemon_v2_itemprices {
      is_purchasable
      purchase_price
      sell_price
      pokemon_v2_versiongroup {
        id
        name
      }
    }
  }
}

v1beta2: item with itemprice relation

query ItemWithItemprice {
  pokemon_v2_item_by_pk(id: 305) {
    id
    name
    itemprices {
      purchase_price
      sell_price
      currency_id
      currency {
        name
        currencynames {
          name
        }
      }
      versiongroup {
        id
        name
      }
    }
  }
}

{
    "data": {
        "item": [
            {
                "id": 305,
                "name": "tm01",
                "cost": null,
                "itemnames": [
                    {
                        "name": "TM01"
                    }
                ],
                "itemprices": [
                    {
                        "purchase_price": 3000,
                        "sell_price": 1500,
                        "currency_id": 1,
                        "currency": {
                            "name": "poke-dollar",
                            "currencynames": [
                                {
                                    "name": "Pokémon Dollar"
                                }
                            ]
                        },
                        "versiongroup": {
                            "id": 1,
                            "name": "red-blue"
                        }
                    },
                    {
                        "purchase_price": 3000,
                        "sell_price": 1500,
                        "currency_id": 1,
                        "currency": {
                            "name": "poke-dollar",
                            "currencynames": [
                                {
                                    "name": "Pokémon Dollar"
                                }
                            ]
                        },
                        "versiongroup": {
                            "id": 2,
                            "name": "yellow"
                        }
                    },
                    {
                        "purchase_price": null,
                        "sell_price": 1500,
                        "currency_id": 1,
                        "currency": {
                            "name": "poke-dollar",
                            "currencynames": [
                                {
                                    "name": "Pokémon Dollar"
                                }
                            ]
                        },
                        "versiongroup": {
                            "id": 3,
                            "name": "gold-silver"
                        }
                    }
                ]
            }
        ]
    }
}

anhthang · 2026-03-08T12:53:46Z

Hi @Naramsim! Could you share your thoughts on the new ItemPrice model and the prices API shape? I'd like to confirm this is the right direction.

Naramsim · 2026-03-10T15:59:29Z

Hi! Thanks for the implementation. Would it be fine to remove the is_purchasable property?

By looking at the value of purchase_price we can understand whether we can buy it or not? If it's null we cannot, if it's an integer we can. What do you think?

Naramsim · 2026-03-10T16:01:46Z

In regard to this issue #1404, RamType0 could you review this PR?

Naramsim · 2026-03-10T16:05:02Z

pokemon_v2/migrations/0001_squashed_0002_auto_20160301_1408.py

                    ),
                ),
                ("name", models.CharField(max_length=100)),
-                ("cost", models.IntegerField(null=True, blank=True)),


We shouldn't touch old migration files.

Should we remove the cost field in a new migration since it's no longer used?

anhthang · 2026-03-10T16:13:12Z

Hi! Thanks for the implementation. Would it be fine to remove the is_purchasable property?

By looking at the value of purchase_price we can understand whether we can buy it or not? If it's null we cannot, if it's an integer we can. What do you think?

I think it's fine to remove is_purchasable and rely on purchase_price instead.

I'm also wondering how we should handle items that can be obtained via other “currencies” instead of Poké Dollars, like candies or similar resources (for example, TM001). Do you have any ideas on how we could represent that in the pricing model?

I'm also unsure. We would first need a list of all available methods and then discuss the best solution.

…is nullable

anhthang · 2026-03-11T15:31:21Z

Add script to scrape Poké Ball prices from Bulbapedia. If this works well, I'll handle other item categories in separate PRs

Naramsim · 2026-03-12T16:08:22Z

Hi! I posted a reply but it doesn't show up. Maybe I lost my connection while I submitted it. Anyways, regarding all the possible way for obtaining items in the game and all possible currencies that can be used, I'd say: let's understand all possible ways for obtaining items. There are surely many ways, for TM100 I see Spheres, League Points, Berry points, Candies... So it's a mess.

We could either have the cost property expose a list of prices, and in the price we define the unit as well. Now the price is an integer, we could tranform it in a string, so that we can do things like:

{
    "id": 305,
    "name": "some-item-name",
    "fling_power": null,
    "fling_effect": null,
    "category": {
        "name": "held-items"
    },
    "prices": [
        {
            "purchase_price": "$3000",
            "sell_price": "$1500",
            "version_group": {
                "name": "red-blue",
                "url": "https://pokeapi.co/api/v2/version-group/1/"
            }
        },
        {
            "purchase_price": "5 Spheres",
            "sell_price": "3 candies",
            "version_group": {
                "name": "red-blue",
                "url": "https://pokeapi.co/api/v2/version-group/1/"
            }
        },
        ...
    ]
}

or

{
    "id": 305,
    "name": "some-item-name",
    "fling_power": null,
    "fling_effect": null,
    "category": {
        "name": "held-items"
    },
    "prices": [
        {
            "purchase_price": ["$3000","2 Battle exp point"],
            "sell_price": ["$1500","3 Candies"],
            "version_group": {
                "name": "red-blue",
                "url": "https://pokeapi.co/api/v2/version-group/1/"
            }
        },
        ...
    ]
}

This way doesn't account for conditions though. More over the price maybe changes based on the location where it's purchased. I'm not that knowledgable.

anhthang · 2026-03-13T02:26:07Z

"purchase_price": ["$3000","2 Battle exp point"],
"sell_price": ["$1500","3 Candies"]

This might be difficult for users to parse and work with.

Could we add a new currencies.csv model for this? I think it would be easier to extend in the future.

id,identifier,name
1,poke-dollar,Poké Dollar
2,battle-point,Battle Point
3,sphere,Sphere
4,candy,Candy
5,berry-point,Berry Point

{
  "purchase_price": 3000,
  "sell_price": 1500,
  "currency_id": 1,
  "version_group": {
    "name": "red-blue",
    "url": "https://pokeapi.co/api/v2/version-group/1/"
  }
}

Naramsim · 2026-03-13T19:31:44Z

Could be good! Let's list them here first

anhthang · 2026-03-14T04:50:44Z

id,identifier
1,poke-dollar
2,coin
3,volcanic-ash
4,poke-coupon
5,berry-powder
6,battle-point
7,sphere
8,castle-point
9,watt
10,athlete-point
11,dream-point
12,dream-world-berry
13,poke-mile
14,festival-coin
15,poke-bean
16,home-point
17,merit-point
18,league-point
19,blueberry-point

id,language_id,name
1,9,Pokémon Dollar
2,9,Coin
3,9,Volcanic Ash
4,9,Poké Coupon
5,9,Berry Powder
6,9,Battle Point
7,9,Sphere
8,9,Castle Point
9,9,Watt
10,9,Athlete Point
11,9,Dream Point
12,9,Berry (Dream World)
13,9,Poké Mile
14,9,Festival Coin
15,9,Poké Bean
16,9,Pokémon HOME Point
17,9,Merit Point
18,9,League Point
19,9,Blueberry Point

I think we can go with these options from Bulbapedia. Some of them might not be very popular, but I believe it's better to list them all.

Naramsim · 2026-03-14T09:54:47Z

Ok as a starting point. In future we can extend the currency table with info about which game was introduced in, or in which game it is usable. We can even add the prose so we can translate it and have a small description.

anhthang · 2026-03-17T04:27:54Z

@Naramsim I have tested and updated response for both REST and GraphQL. Please review again

Naramsim

We could also:

Announce the change with an alert on the website
Keep the current property as it is now and the new one alongside each other for a limited period so to give people time to update? Maybe this is not possible since the property name is the same?

Naramsim · 2026-04-04T13:25:38Z

pokemon_v2/urls.py

 router.register(r"item-attribute", ItemAttributeResource)
 router.register(r"item-fling-effect", ItemFlingEffectResource)
 router.register(r"item-pocket", ItemPocketResource)
+router.register(r"currency", CurrencyResource)


Hi @anhthang sorry for coming back after so long. Could you prepare a PR over at pokeapi with the new endpoint and the new properties documented?

Where I should go to document the new endpoint?

Naramsim · 2026-04-04T13:27:06Z

scripts/scraping_pokeball_price.py

@@ -0,0 +1,240 @@
+import requests


Could you add a comment on top of this file stating that it's you that created it and is able ot understand it? Can you create a separate PR doing the same for all the other script you created in this repo and in the sprites repo as well?

Yes, I can do it. For the sprites, I think I did it already previously and the new PR is just rerun the script

anhthang · 2026-04-05T02:33:12Z

Announce the change with an alert on the website

Yes we can do that

Keep the current property as it is now and the new one alongside each other for a limited period so to give people time to update? Maybe this is not possible since the property name is the same?

I dont think this is needed since lot of data is missing now and incorrect value. So removing it mean data is missing again and people can update to the new one with the announcement above

anhthang marked this pull request as draft March 7, 2026 16:21

anhthang force-pushed the item-prices branch 3 times, most recently from 0d594ce to 4423e08 Compare March 9, 2026 07:09

anhthang marked this pull request as ready for review March 9, 2026 10:23

anhthang marked this pull request as draft March 9, 2026 14:21

anhthang marked this pull request as ready for review March 10, 2026 14:47

Naramsim reviewed Mar 10, 2026

View reviewed changes

anhthang added 9 commits March 11, 2026 22:28

feat(data): add ItemPrice model and serializer for item pricing data

6f10308

add is_purchasable

8db5291

feat(api): add ItemPrice resource and add item prices, remove item cost

a47fbb1

remove cost from build, test and migration

e127186

correct tm01, tm02

ca81ac4

fix: purchase_price and sell_price should be nullable

bd8de1f

update openapi specs, fix Location.region and Region.main_generation …

3b86938

…is nullable

remove is_purchasable

af5b7d3

add script to scraping pokeball price

b49c15e

anhthang force-pushed the item-prices branch from b26d204 to b49c15e Compare March 11, 2026 15:29

fix: update item prices and handle N/A values in scraping script

0798ac0

anhthang requested a review from Naramsim March 12, 2026 14:22

anhthang added 2 commits March 14, 2026 22:14

add currency

b3577b0

add currency to scrape script

c22b2b1

Naramsim mentioned this pull request Apr 3, 2026

Add all game corner encounters #1467

Merged

Naramsim requested changes Apr 4, 2026

View reviewed changes

Uh oh!

Conversation

anhthang commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Example REST API response

Example GraphQL queries

v1beta: item with prices

v1beta2: item with itemprice relation

Uh oh!

anhthang commented Mar 8, 2026

Uh oh!

Naramsim commented Mar 10, 2026

Uh oh!

Naramsim commented Mar 10, 2026

Uh oh!

Naramsim Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

anhthang Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

anhthang commented Mar 10, 2026 • edited by Naramsim Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anhthang commented Mar 11, 2026

Uh oh!

Naramsim commented Mar 12, 2026

Uh oh!

anhthang commented Mar 13, 2026

Uh oh!

Naramsim commented Mar 13, 2026

Uh oh!

anhthang commented Mar 14, 2026

Uh oh!

Naramsim commented Mar 14, 2026

Uh oh!

anhthang commented Mar 17, 2026

Uh oh!

Naramsim left a comment

Choose a reason for hiding this comment

Uh oh!

Naramsim Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

anhthang Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

Naramsim Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

anhthang Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

anhthang commented Apr 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

anhthang commented Mar 7, 2026 •

edited

Loading

anhthang commented Mar 10, 2026 •

edited by Naramsim

Loading