fix waterlogged bucket incorrect logging (Resolves #858)#860
Open
guss-alberto wants to merge 1 commit intoPlayPro:masterfrom
Open
fix waterlogged bucket incorrect logging (Resolves #858)#860guss-alberto wants to merge 1 commit intoPlayPro:masterfrom
guss-alberto wants to merge 1 commit intoPlayPro:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fix for Issue #858
By using
event.getBlock()instead ofevent.getBlockClicked()there is no longer the need to manually check for waterlogged blocks and offset the position, as that's handled by Bukkit.The
getBlock()method is still present in older versions as far back as 1.14, so compatibility isn't affected.Although the bug only affects bucket emptying, I've also changed it on
bucketFillListenerjust for consistency, the result doesn't actually change.I've tested this fix, and everything works as expected.