Skip to content

Fix the bug where Speed=0 prevents two cases #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeathFishAtEase wants to merge 5 commits into
base: develop
Choose a base branch
from
+12 −3
Open

Fix the bug where Speed=0 prevents two cases #2188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1e0d81f
initial
DeathFishAtEase May 2, 2026
79a2f80
Merge branch 'develop' into TryToFixSpeed0
DeathFishAtEase May 2, 2026
2d9c2b6
`JumpjetAccel=0.0` causes VehicleType with `Locomotor=Jumpjet` to rem…
DeathFishAtEase May 2, 2026
b57fa2b
Update docs
DeathFishAtEase May 2, 2026
d052e28
Merge remote-tracking branch 'Phobos-developers/develop' into TryToFi…
DeathFishAtEase May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/Fixed-or-Improved-Logics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2335,7 +2335,7 @@ Sinkable.SquidGrab=true ; boolean

### Stationary vehicles

- Setting VehicleType `Speed` to 0 now makes game treat them as stationary, behaving in very similar manner to deployed vehicles with `IsSimpleDeployer` set to true. Should not be used on buildable vehicles, as they won't be able to exit factories.
- Setting `JumpjetAccel` to 0 for VehicleTypes with `Locomotor=Jumpjet` or setting `Speed` to 0 for other now makes game treat them as stationary, behaving in very similar manner to deployed vehicles with `IsSimpleDeployer` set to true. Should not be used on buildable vehicles, as they won't be able to exit factories.

### Turret recoil

Expand Down
1 change: 1 addition & 0 deletions docs/Whats-New.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,6 +697,7 @@ Phobos fixes:
- Fixed a bug causing transfering AttachEffects (e.g on `DeploysInto`/`UndeploysInto`) not to immediately recalculate stats or tint (by Starkku)
- Fixed a bug where updating the `OpenTopped` attribute during convert did not update the coordinates of passengers (by NetsuNegi)
- Fixed `Shrapnel.AffectsBuildings=true` shrapnel weapons being able to hit the building itself, potentially multiple times, if it had foundation larger than 1x1 (by Starkku)
- Fixed a bug where stationary vehicles would also block movement caused by external factors (by Noble_Fish)

Fixes / interactions with other extensions:
<!-- - Allowed `AuxBuilding` and Ares' `SW.Aux/NegBuildings` to count building upgrades (by Ollerus) -->
Expand Down
12 changes: 10 additions & 2 deletions src/Ext/Techno/Body.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "Body.h"
#include "Body.h"

#include <JumpjetLocomotionClass.h>

Expand Down Expand Up @@ -750,9 +750,17 @@ bool TechnoExt::IsHealthInThreshold(TechnoClass* pObject, double min, double max

bool TechnoExt::CannotMove(UnitClass* pThis)
{
if (pThis->LocomotorSource)
return false;

const auto pType = pThis->Type;

if (pType->Speed == 0)
if ((pType->Speed == 0
&& (pType->Locomotor != LocomotionClass::CLSIDs::Jumpjet
|| pType->Teleporter))
|| (pType->Locomotor == LocomotionClass::CLSIDs::Jumpjet
&& !pType->Teleporter
&& pType->JumpjetAccel == 0.0))
return true;

const auto movementRestrictedTo = pType->MovementRestrictedTo;
Expand Down
Loading