Issue: Consistent dimensions order #2374#2663
Merged
erikvansebille merged 6 commits intoJun 16, 2026
Merged
Conversation
for more information, see https://pre-commit.ci
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
Looks good, two small comments
| "Y": grid_positions["Y"]["index"], | ||
| "Z": grid_positions["Z"]["index"], | ||
| } | ||
| } # TODO check if reordering to Z,Y,X for dimension order consistency is possible |
Member
There was a problem hiding this comment.
So still needs to be done?
Contributor
Author
There was a problem hiding this comment.
yes, but no change needed and comment is removed.
erikvansebille
approved these changes
Jun 16, 2026
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
Looks good; thanks for your contribution, @PeterWolfram
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed dimension order to time,z,lat,lon or time,z,y,x for consistency
As requested in issue #2374 changed order of dimensions to be consistent throughout the code.