Fix stabbing with a spear not triggering the left-click event#13780
Open
bluelhf wants to merge 3 commits intoPaperMC:mainfrom
Open
Fix stabbing with a spear not triggering the left-click event#13780bluelhf wants to merge 3 commits intoPaperMC:mainfrom
bluelhf wants to merge 3 commits intoPaperMC:mainfrom
Conversation
…n clicks on blocks
Owen1212055
requested changes
Apr 25, 2026
Member
Owen1212055
left a comment
Owen1212055
left a comment
There was a problem hiding this comment.
Hey! This isn't exactly the most ideal solution.
Rather, you should call the interaction event in the STAB action that is sent from the client. The swing detection is largely a hack.
github-project-automation
Bot
moved this from Awaiting review
to Changes required
in Paper PR Queue
Contributor
Author
I considered that, but I was unsure how we'd go about detecting the target block. I'd rather not duplicate the ray tracing logic, and for STAB, the face and location sent in the packet are always -Y and (0, 0, 0). |
the only remaining bug is because of the problematic maxRange calculation (which was that way before)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13779
Spears do not send block break player actions in the same way as swords, but instead their own Stab action. Because of this, the usual handling for block interaction events does not work. An additional condition is added to allow the swing packet sent for piercing weapon attacks to trigger the interaction event.