Skip to content

build: Update rust toolchain version#5705

Merged
prql-bot merged 3 commits intomainfrom
update_rust_toolchain_action
Mar 10, 2026
Merged

build: Update rust toolchain version#5705
prql-bot merged 3 commits intomainfrom
update_rust_toolchain_action

Conversation

@prql-bot
Copy link
Collaborator

@prql-bot prql-bot commented Mar 6, 2026

Automatic change by the update-rust-toolchain Github Action.

Github Actions will not run workflows on pull requests which are opened by a GitHub Action.

For examples on how to run workflows on this pr, please go to the readme.

@prql-bot prql-bot enabled auto-merge (squash) March 6, 2026 11:02
@prql-bot prql-bot force-pushed the update_rust_toolchain_action branch from 18b3652 to be98a98 Compare March 10, 2026 11:05
@max-sixty
Copy link
Member

@claude please fix

@claude
Copy link

claude bot commented Mar 10, 2026

Claude finished @max-sixty's task in 4s —— View job


Fixing Rust Toolchain Update PR ✅

  • Gather context (check CI status, view diff)
  • Identify issues:
    1. Clippy error: called unwrap() on expr.target_id after checking its variant with is_some (new lint in Rust 1.93.1)
    2. Windows stack overflow in long_query CLI test (exit code -1073741571 / 0xC00000FD)
  • Fix clippy issue — used if let Some() with .filter() instead of is_some() + unwrap()
  • Fix Windows stack overflow — spawn CLI main in thread with 8 MiB stack
  • Run tests locally — all passing (56 lib + 430 integration + 25 bin tests)
  • Push fixes (deb89ab4, 4f919b2e)
  • CI passing ✅

Both issues from the Rust 1.92 → 1.93.1 upgrade are now fixed and CI is fully green.

View CI run · ·

github-actions bot and others added 2 commits March 10, 2026 20:19
Use `if let Some()` with `.filter()` instead of `is_some()` + `unwrap()`
to satisfy the new clippy lint in Rust 1.93.1.

Co-authored-by: Maximilian Roos <max-sixty@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rust 1.93.1 uses more stack space, causing stack overflow on Windows
where the default stack is only 1 MiB. Spawn the CLI main function
in a thread with an 8 MiB stack.

Co-authored-by: Maximilian Roos <max-sixty@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@prql-bot prql-bot merged commit fb522f7 into main Mar 10, 2026
76 checks passed
@prql-bot prql-bot deleted the update_rust_toolchain_action branch March 10, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants