Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2854 +/- ##
=======================================
Coverage 48.21% 48.21%
=======================================
Files 112 112
Lines 4835 4835
Branches 1338 1338
=======================================
Hits 2331 2331
Misses 2500 2500
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…m/OriginProtocol/origin-dollar into sparrowDom/automated-actions-lite-chris2
- Add TypeScript, ESLint TS, and Prettier TS support to contracts/ - Create action() registration pattern for hardhat tasks with Winston logging - Convert 13 Defender actions to self-registering TS hardhat tasks - Add Loki transport for centralized logging - Add healthcheck task for validation - Fix ssv-scanner dependency (bloxapp → ssvlabs) - Fix @lodestar/types ESM compatibility via ts-node skipProject
…om/automated-actions-lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a cron runtime supervisor for the Docker deployment that:
supercronicscheduling from JSON configAWS KMS Signer Usage
Cron/manual actions still execute existing Hardhat tasks, so signer behavior is unchanged and continues to use the repo signer selection logic:
AWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEYare present, the task path selects AWS KMS signing.DirectKmsTransactionSigner(purrikey) with the configured relayer key id and region.utils/txLogger), so run-level tx IDs are visible in container logs/Loki.Cronjobs Configured via JSON
Cron configuration is now JSON-first:
contracts/cron/cron-jobs.jsonname(string)schedule(5-field cron expression)enabled(boolean)command(string)/etc/cronjob(with# <name>comments) and started viasupercronic.Cronjobs Triggered via API
A lightweight Node HTTP server is started with the container runtime and runs alongside
supercronic./api/v1/*ACTION_API_BEARER_TOKEN(required)POST /api/v1/actions/:name/runs202 Acceptedwith:runIdactionstatusstatusUrlstartedAtLocationheader pointing to run status URLqueued -> running -> succeeded|failed)enabled=false500)Cron Configuration / Run Status via API
GET /api/v1/actionsname,schedule,enabledGET /api/v1/runs/:runIdstatusstartedAtfinishedAtexitCodesignalGET /healthz(no auth)supercronicis runningRuntime Notes
node /app/scripts/cron-supervisor.js).HOST(default0.0.0.0)PORT(default8080)ACTION_RUN_HISTORY_LIMIT(default500)ACTION_WORKDIR(default/app)