Skip to content

Install required packages for linperf.sh #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leochr merged 2 commits into from
Aug 18, 2025
Merged

Install required packages for linperf.sh #159

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc250fe
Install required packages for linperf.sh
kabicin Aug 7, 2025
c3321c7
Add comment and parenthesize the package command
kabicin Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ LABEL \
summary="Sample app running on Open Liberty that uses Eclipse MicroProfile" \
description="This image contains a sample application that displays the Java system properties and demonstrates MicroProfile Config, Health and Metrics."

USER 0
RUN command -v yum && pkgcmd=yum || pkgcmd=microdnf && $pkgcmd update -y && $pkgcmd install -y procps-ng net-tools ncurses hostname
Copy link
Copy Markdown
Member

@leochr leochr Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: use parentheses to separate the conditions, so it's clear / no ambiguity in the evaluation

Copy link
Copy Markdown
Member Author

@kabicin kabicin Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$pkgcmd will lose scope once parenthesized, however the && and || have equal precedence and will be evaluated from left to right. For better readability, I parenthesized the update/install command at the end.

USER 1001

COPY --chown=1001:0 src/main/liberty/config/ /config/

RUN features.sh
Expand Down
Loading