Skip to content

ci: let a pull request keep the image it just built #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
widgetii merged 2 commits into from
Aug 27, 2026
Merged

ci: let a pull request keep the image it just built #135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7530413
ci: let a pull request keep the image it just built
widgetii Aug 27, 2026
b14cc52
ci: scope the longer artifact retention to pull requests
widgetii Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions .github/workflows/master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,14 @@ jobs:
# schemes the build used (compound devices rename to <device>-nor.tgz in
# the workspace root, simple ones leave openipc.<soc>-nor-<variant>.tgz
# under openipc/output/images/).
# Runs on pull_request too. Staging and the upload below are run-scoped
# and touch no secret and no shared state, so unlike `Send binary` and the
# `publish` job -- which stay gated, and must -- there is nothing here for
# a PR to leak or clobber. Without this a contributor's PR compiles a full
# image and then discards it, so they cannot test their own device profile
# without asking a maintainer to dispatch build-one for them.
- name: Stage artifacts
if: >-
github.event_name != 'pull_request' &&
(env.NORFW || env.NANDFW)
if: env.NORFW || env.NANDFW
run: |
mkdir -p dist
for f in "${NORFW:-}" "${NANDFW:-}" "${SIZES:-}"; do
Expand All @@ -297,15 +301,24 @@ jobs:
# contention (run 27108181857: every board built, 14 jobs red in their
# upload step). Consolidating every release write into one job removes the
# concurrent-writer contention that causes it.
#
# `publish` carries its own `github.event_name != 'pull_request'`, so
# producing fw-* on a PR cannot reach a release; it only makes the image
# downloadable from the run that built it.
#
# Retention is per-event deliberately. A nightly's artifact is consumed by
# `publish` inside the same run and no one downloads it afterwards, and a
# nightly builds the entire device matrix -- holding those a week would
# keep seven full matrices in storage instead of one, for no reader. A PR
# builds a handful and has a person waiting on them, plausibly in another
# timezone, so one day is too short a window there.
- name: Upload build artifacts
if: >-
github.event_name != 'pull_request' &&
(env.NORFW || env.NANDFW)
if: env.NORFW || env.NANDFW
uses: actions/upload-artifact@v4
with:
name: fw-${{ matrix.platform }}
if-no-files-found: ignore
retention-days: 1
retention-days: ${{ github.event_name == 'pull_request' && 7 || 1 }}
path: dist/*

- name: Send binary
Expand Down
Loading