fix(sdk): cap effective_max_output_tokens with DEFAULT_MAX_OUTPUT_TOKENS_CAP#3319
Open
vanhci wants to merge 1 commit into
Open
fix(sdk): cap effective_max_output_tokens with DEFAULT_MAX_OUTPUT_TOKENS_CAP#3319vanhci wants to merge 1 commit into
vanhci wants to merge 1 commit into
Conversation
…ENS_CAP for all providers
Collaborator
|
[Automatic Post]: I have assigned @juanmichelini as a reviewer based on git blame information. Thanks in advance for the help! This comment was created by an AI agent (OpenHands) on behalf of the user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3317. When litellm model metadata reports a max_output_tokens value that exceeds the model's actual API limit (e.g., moonshot/kimi-k2.5 through custom base_url), apply DEFAULT_MAX_OUTPUT_TOKENS_CAP (16384) as a universal safety cap. This generalizes the fix from #2264 which only handled bedrock/ models.