Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1808 +/- ##
==========================================
- Coverage 94.79% 91.18% -3.62%
==========================================
Files 205 206 +1
Lines 17957 18247 +290
==========================================
- Hits 17022 16638 -384
- Misses 935 1609 +674
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
pre-commit.ci autofix |
|
pre-commit.ci autofix |
| return reporter | ||
|
|
||
| @staticmethod | ||
| def _get_sampler( |
There was a problem hiding this comment.
This method is annoyingly close to the RFE one, but also annoyingly just a bit different.. (because sampler building goes through extra hoops in hybrid topology sims). It might be hard to align them in the future without fixing sampler.create in hybrid topology sims.
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Co-authored-by: Josh Horton <Josh.Horton@newcastle.ac.uk>
jthorton
left a comment
There was a problem hiding this comment.
This is great, I think this is highlighting places where we can deduplicate across protocols in the future as well. Please merge after fixing the missing file error to be more specific.
|
No API break detected ✅ |
Fixes #1725
Similar to #1774
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin