Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1561 +/- ##
==========================================
- Coverage 94.62% 90.66% -3.97%
==========================================
Files 206 206
Lines 18285 18758 +473
==========================================
- Hits 17303 17007 -296
- Misses 982 1751 +769
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…y/openfe into membrane_prototype
…y/openfe into membrane_prototype
…y/openfe into membrane_prototype
…y/openfe into membrane_prototype
for more information, see https://pre-commit.ci
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
jthorton
left a comment
There was a problem hiding this comment.
Great job, everyone. This is finally ready pending the highlighted changes.
Co-authored-by: Josh Horton <Josh.Horton@newcastle.ac.uk>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
|
Running long CPU tests here: https://github.com/OpenFreeEnergy/openfe/actions/runs/24508465814 |
|
Running GPU tests here: https://github.com/OpenFreeEnergy/openfe/actions/runs/24508496073 |
|
No API break detected ✅ |
|
Only failing CPU long test is the one related to #1941 - so we should be good to go. |
[Note from @atravitz: we are making an experimental release from this branch, and so this branch should not be merged into main just yet]
This PR addresses the following issues:
Checklist
newsentryDevelopers certificate of origin