Skip to content

Membrane support#1561

Merged
IAlibay merged 231 commits intomainfrom
membrane_prototype
Apr 16, 2026
Merged

Membrane support#1561
IAlibay merged 231 commits intomainfrom
membrane_prototype

Conversation

@hannahbaumann
Copy link
Copy Markdown
Contributor

@hannahbaumann hannahbaumann commented Oct 9, 2025

[Note from @atravitz: we are making an experimental release from this branch, and so this branch should not be merged into main just yet]

This PR addresses the following issues:

Checklist

  • Added a news entry

Developers certificate of origin

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 66.78201% with 192 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.66%. Comparing base (c60db06) to head (5f3e876).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ts/protocols/openmm_septop/test_septop_protocol.py 31.54% 115 Missing ⚠️
...s/protocols/openmm_rfe/test_hybrid_top_protocol.py 8.57% 32 Missing ⚠️
.../tests/protocols/openmm_abfe/test_abfe_protocol.py 70.29% 30 Missing ⚠️
src/openfe/protocols/openmm_md/plain_md_methods.py 81.25% 3 Missing ⚠️
...openfe/protocols/openmm_rfe/_rfe_utils/relative.py 66.66% 2 Missing ⚠️
...nfe/protocols/openmm_septop/equil_septop_method.py 90.90% 2 Missing ⚠️
src/openfe/protocols/openmm_utils/omm_settings.py 84.61% 2 Missing ⚠️
src/openfe/protocols/openmm_afe/abfe_units.py 80.00% 1 Missing ⚠️
src/openfe/protocols/openmm_afe/base_afe_units.py 66.66% 1 Missing ⚠️
...openfe/protocols/openmm_rfe/hybridtop_protocols.py 90.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
- Coverage   94.62%   90.66%   -3.97%     
==========================================
  Files         206      206              
  Lines       18285    18758     +473     
==========================================
- Hits        17303    17007     -296     
- Misses        982     1751     +769     
Flag Coverage Δ
fast-tests 90.66% <66.78%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hannahbaumann and others added 4 commits April 15, 2026 15:01
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Comment thread src/openfe/tests/protocols/openmm_abfe/test_abfe_protocol.py Outdated
Comment thread src/openfe/tests/protocols/openmm_rfe/test_hybrid_top_protocol.py
Copy link
Copy Markdown
Collaborator

@jthorton jthorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, everyone. This is finally ready pending the highlighted changes.

hannahbaumann and others added 5 commits April 16, 2026 11:26
Co-authored-by: Josh Horton <Josh.Horton@newcastle.ac.uk>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
@hannahbaumann
Copy link
Copy Markdown
Contributor Author

pre-commit.ci autofix

Copy link
Copy Markdown
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things left.

Comment thread src/openfe/protocols/openmm_afe/equil_binding_afe_method.py Outdated
Comment thread src/openfe/protocols/openmm_septop/equil_septop_method.py Outdated
Comment thread src/openfe/protocols/openmm_utils/system_creation.py
Comment thread src/openfe/tests/protocols/openmm_abfe/test_abfe_protocol.py
hannahbaumann and others added 3 commits April 16, 2026 13:21
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
@IAlibay
Copy link
Copy Markdown
Member

IAlibay commented Apr 16, 2026

Running long CPU tests here: https://github.com/OpenFreeEnergy/openfe/actions/runs/24508465814

@IAlibay
Copy link
Copy Markdown
Member

IAlibay commented Apr 16, 2026

Copy link
Copy Markdown
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending test passing, LGTM!

@github-actions
Copy link
Copy Markdown

No API break detected ✅

@IAlibay
Copy link
Copy Markdown
Member

IAlibay commented Apr 16, 2026

Only failing CPU long test is the one related to #1941 - so we should be good to go.
I'll merge once conventional CI turns green.

@IAlibay IAlibay merged commit 0af4cab into main Apr 16, 2026
9 of 10 checks passed
@IAlibay IAlibay deleted the membrane_prototype branch April 16, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Membrane: Add warning/validation for barostat usage

4 participants