avoid duplicate Content-Length header in DefaultClient#3451
Open
alhudz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: send a body-less
POST/PUTwhose template already carries aContent-Lengthheader (e.g.@Headers("Content-Length: 0")), withsun.net.http.allowRestrictedHeaders=trueso the header reaches the wire.Cause:
DefaultClient.convertAndSendwrites the requestContent-Lengthin the header loop and then unconditionally adds a secondContent-Length: 0for every body-less method that allows a body, so the field goes out twice. RFC 7230 §3.3.2 forbids generating multipleContent-Lengthfields; the duplicate is ambiguous framing and servers reject it (Tomcat returns400, #2862).Fix: only add the fallback
Content-Length: 0when the request does not already declare aContent-Length.The regression test is gated on
sun.net.http.allowRestrictedHeaderslike the existingContent-Lengthtests, sinceHttpURLConnectionotherwise drops the restricted header, and asserts the field is sent once.