Fix fluent methods on cloned builders#3449
Open
hutiefang76 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2782.
BaseBuildercachedthisin a finalthisBfield. When a builder is cloned, that final field is copied as-is, so fluent methods invoked on the clone still return the original builder instance. This can make chained configuration on cloned builders silently continue on the wrong object.This keeps the existing self-type helper pattern but makes it resolve
thisdynamically through one private helper method instead of storing it in a clone-stale field. That avoids the broader refactor from #2783 and keeps the unchecked cast centralized.Validation:
The full
coretest run passed 635 tests with 0 failures/errors and 3 skipped tests.